Ship the "View in Mollie" label in every back office language

The label added in PIPRES-786 shipped in English only, so every non-English
back office showed the source string on the Orders list and the order page.

The string is looked up from two translation sources, the order_info template
and OrderGridDefinitionModifier, so each catalog needs both keys. Added them
to all 24 shipped catalogs. The "Mollie" column header is a brand name and is
intentionally left untranslated.

Extended the PIPRES-802 catalog test to cover every shipped locale instead of
only en, nl and fr, asserting both keys exist, agree with each other, and are
not the English source string outside en.php.

Author: Tadas Labutis

changelog.md

@@ -13,6 +13,7 @@
 + Fixed total_paid_real staying 0 on bank transfer orders after the payment is completed
 + Fixed free shipping vouchers causing a Mollie API 422 amount error at checkout, and wrong order line amounts when no payment fee is configured
 + Fixed Apple Pay Direct failing to complete guest payments, the shipping address selected in the Apple Pay sheet was dropped from the cart before the order was created
++ Translated the "View in Mollie" link into all supported back office languages
 
 ## Changes in release 6.4.4
 + Added a "View in Mollie" link on the order page and in the Orders list to open a payment directly in the Mollie dashboard

tests/Unit/Grid/Definition/Modifier/OrderGridDefinitionModifierTest.php

@@ -36,6 +36,7 @@ class OrderGridDefinitionModifierTest extends TestCase
     const TRANSLATION_SOURCE = 'OrderGridDefinitionModifier';
     const HEADER = 'Resend payment link';
     const TOOLTIP = 'You will resend email with payment link to the customer';
+    const VIEW_IN_MOLLIE = 'View in Mollie';
 
     /**
      * The shipped catalogs must contain the exact keys that Mollie::l() looks up for this modifier,
@@ -67,6 +68,55 @@ public function testShippedCatalogsTranslateTheResendColumnStrings()
         }
     }
 
+    /**
+     * Regression for PIPRES-810: the "View in Mollie" label (PIPRES-786) shipped in English only, so
+     * every non-English back office showed the source string on the Orders list and the order page.
+     * The label is looked up from two sources - the order_info template and this grid modifier - so
+     * both keys must exist, and must agree, in every shipped catalog.
+     */
+    public function testShippedCatalogsTranslateTheViewInMollieLabel()
+    {
+        $hash = md5(self::VIEW_IN_MOLLIE);
+        $templateKey = '<{mollie}prestashop>order_info_' . $hash;
+        $gridKey = '<{mollie}prestashop>' . strtolower(self::TRANSLATION_SOURCE) . '_' . $hash;
+        $translationsDir = dirname(__DIR__, 5) . '/translations';
+
+        $catalogs = glob($translationsDir . '/*.php');
+        $this->assertNotEmpty($catalogs, 'No shipped translation catalogs were found.');
+
+        $checked = 0;
+        foreach ($catalogs as $catalog) {
+            $iso = basename($catalog, '.php');
+            if ('index' === $iso) {
+                continue;
+            }
+
+            ++$checked;
+            $_MODULE = [];
+            include $catalog;
+
+            $this->assertArrayHasKey($templateKey, $_MODULE, sprintf('Missing order page translation in %s.php', $iso));
+            $this->assertArrayHasKey($gridKey, $_MODULE, sprintf('Missing Orders list translation in %s.php', $iso));
+            $this->assertNotSame('', trim((string) $_MODULE[$templateKey]), sprintf('Empty order page translation in %s.php', $iso));
+            $this->assertSame(
+                $_MODULE[$templateKey],
+                $_MODULE[$gridKey],
+                sprintf('The order page and Orders list labels must match in %s.php', $iso)
+            );
+
+            if ('en' !== $iso) {
+                $this->assertNotSame(
+                    self::VIEW_IN_MOLLIE,
+                    $_MODULE[$gridKey],
+                    sprintf('Label in %s.php should be localized, not the English source string', $iso)
+                );
+            }
+        }
+
+        // Guards against the glob silently matching nothing but index.php.
+        $this->assertGreaterThan(1, $checked, 'Expected the shipped locale catalogs to be checked.');
+    }
+
     /**
      * The modifier must build the column header and the resend tooltip via the module's legacy
      * translator (Mollie::l) with this modifier's own source, not the Symfony translator. Skips when

translations/bg.php

@@ -397,6 +397,7 @@
 $_MODULE['<{mollie}prestashop>mollie_iframe_fc7775bdfa339217149389b7392af83b'] = 'Запази картата';
 $_MODULE['<{mollie}prestashop>mollie_iframe_ee2b8214cd8479d18e873181505b48ea'] = 'Използвайте запазената карта';
 $_MODULE['<{mollie}prestashop>mollie_iframe_49753ba0559e716a708373951ea87d1c'] = 'Сигурни плащания, предоставени от';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'Преглед в Mollie';
 $_MODULE['<{mollie}prestashop>order_info_bcd372e1d75ca10ce207ef3ef14379d1'] = 'Няма налични продукти за тази поръчка, защото е направена преди версия 6.4.1 на Mollie. Все още можете да използвате действията за възстановяване, прихващане или изпращане.';
 $_MODULE['<{mollie}prestashop>order_info_81f04888e2363d334eeee1d13885509d'] = 'Сума за възстановяване (Макс: %s)';
 $_MODULE['<{mollie}prestashop>order_info_88b6563ca5cac4845361c28959c5612e'] = 'Стартиране на възстановяване';
@@ -442,6 +443,7 @@
 $_MODULE['<{mollie}prestashop>installer_77240e73b3e9b64c47052880f87b6a8b'] = 'Не може да се инсталират атрибутите на ваучерите';
 $_MODULE['<{mollie}prestashop>installer_407748408f99fed49e067dee67df619c'] = 'Не можаха да се копират шаблоните на имейлите:';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'Ще изпратите отново имейл с линк за плащане на клиента';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'Преглед в Mollie';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'Ще изпратите отново имейл с линк за плащане на клиента';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Повторно изпращане на линк за плащане';
 $_MODULE['<{mollie}prestashop>paymentfeeprovider_a1fa8d7a9942f24895492dcaf7f3e16d'] = 'Отстъпка: %1s';

translations/cs.php

@@ -421,6 +421,7 @@
 $_MODULE['<{mollie}prestashop>mollie_iframe_fc7775bdfa339217149389b7392af83b'] = 'Uložit kartu';
 $_MODULE['<{mollie}prestashop>mollie_iframe_ee2b8214cd8479d18e873181505b48ea'] = 'Použít uloženou kartu';
 $_MODULE['<{mollie}prestashop>mollie_iframe_49753ba0559e716a708373951ea87d1c'] = 'Zabezpečené platby prostřednictvím';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'Zobrazit v Mollie';
 $_MODULE['<{mollie}prestashop>order_info_bcd372e1d75ca10ce207ef3ef14379d1'] = 'Pro tuto objednávku nejsou k dispozici žádné produkty, protože byla zadána před verzí Mollie 6.4.1. Stále můžete použít akce pro vrácení peněz, zachycení nebo odeslání.';
 $_MODULE['<{mollie}prestashop>order_info_81f04888e2363d334eeee1d13885509d'] = 'Částka k vrácení (Max: %s)';
 $_MODULE['<{mollie}prestashop>order_info_88b6563ca5cac4845361c28959c5612e'] = 'Zahájit vrácení peněz';
@@ -466,6 +467,7 @@
 $_MODULE['<{mollie}prestashop>installer_77240e73b3e9b64c47052880f87b6a8b'] = 'Nepodařilo se nainstalovat atributy poukazu';
 $_MODULE['<{mollie}prestashop>installer_407748408f99fed49e067dee67df619c'] = 'Nedařilo se zkopírovat šablony e-mailů:';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'Znovu odešlete email s platebním odkazem zákazníkovi';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'Zobrazit v Mollie';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'Znovu odešlete email s platebním odkazem zákazníkovi';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Znovu odeslat platební odkaz';
 $_MODULE['<{mollie}prestashop>paymentfeeprovider_a1fa8d7a9942f24895492dcaf7f3e16d'] = 'Sleva: %1s';

translations/da.php

@@ -421,6 +421,7 @@
 $_MODULE['<{mollie}prestashop>mollie_iframe_fc7775bdfa339217149389b7392af83b'] = 'Gem kort';
 $_MODULE['<{mollie}prestashop>mollie_iframe_ee2b8214cd8479d18e873181505b48ea'] = 'Brug gemt kort';
 $_MODULE['<{mollie}prestashop>mollie_iframe_49753ba0559e716a708373951ea87d1c'] = 'Sikre betalinger leveret af';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'Vis i Mollie';
 $_MODULE['<{mollie}prestashop>order_info_bcd372e1d75ca10ce207ef3ef14379d1'] = 'Ingen produkter er tilgængelige for denne ordre, fordi den blev afgivet før Mollie version 6.4.1. Du kan stadig bruge refunderings-, registrerings- eller forsendelseshandlinger.';
 $_MODULE['<{mollie}prestashop>order_info_81f04888e2363d334eeee1d13885509d'] = 'Refunderingsbeløb (Maks: %s)';
 $_MODULE['<{mollie}prestashop>order_info_88b6563ca5cac4845361c28959c5612e'] = 'Start refundering';
@@ -466,6 +467,7 @@
 $_MODULE['<{mollie}prestashop>installer_77240e73b3e9b64c47052880f87b6a8b'] = 'Kunne ikke installere voucher-attributter';
 $_MODULE['<{mollie}prestashop>installer_407748408f99fed49e067dee67df619c'] = 'Kunne ikke kopiere e-mail skabeloner:';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'Du vil sende e-mail med betalingslink til kunden';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'Vis i Mollie';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'Du vil sende e-mail med betalingslink til kunden';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Send betalingslink igen';
 $_MODULE['<{mollie}prestashop>paymentfeeprovider_a1fa8d7a9942f24895492dcaf7f3e16d'] = 'Rabat: %1s';

translations/de.php

@@ -421,6 +421,7 @@
 $_MODULE['<{mollie}prestashop>mollie_iframe_fc7775bdfa339217149389b7392af83b'] = 'Karte speichern';
 $_MODULE['<{mollie}prestashop>mollie_iframe_ee2b8214cd8479d18e873181505b48ea'] = 'Gespeicherte Karte verwenden';
 $_MODULE['<{mollie}prestashop>mollie_iframe_49753ba0559e716a708373951ea87d1c'] = 'Sichere Zahlung bereitgestellt durch';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'In Mollie ansehen';
 $_MODULE['<{mollie}prestashop>order_info_bcd372e1d75ca10ce207ef3ef14379d1'] = 'Für diese Bestellung sind keine Produkte verfügbar, da sie vor Mollie-Version 6.4.1 aufgegeben wurde. Sie können weiterhin die Aktionen Rückerstattung, Erfassung oder Versand verwenden.';
 $_MODULE['<{mollie}prestashop>order_info_81f04888e2363d334eeee1d13885509d'] = 'Rückerstattungsbetrag (Max: %s)';
 $_MODULE['<{mollie}prestashop>order_info_88b6563ca5cac4845361c28959c5612e'] = 'Rückerstattung einleiten';
@@ -466,6 +467,7 @@
 $_MODULE['<{mollie}prestashop>installer_77240e73b3e9b64c47052880f87b6a8b'] = 'Installation der Gutschein-Attribute nicht möglich';
 $_MODULE['<{mollie}prestashop>installer_407748408f99fed49e067dee67df619c'] = 'Konnte E-Mail-Vorlagen nicht kopieren:';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'Sie werden eine E-Mail mit dem Zahlungslink an den Kunden senden';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'In Mollie ansehen';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'Sie werden eine E-Mail mit dem Zahlungslink an den Kunden senden';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Zahlungslink erneut senden';
 $_MODULE['<{mollie}prestashop>paymentfeeprovider_a1fa8d7a9942f24895492dcaf7f3e16d'] = 'Rabatt: %1s';

translations/el.php

@@ -43,6 +43,7 @@
 $_MODULE['<{mollie}prestashop>qr_code_ea4788705e6873b424c65e91c2846b19'] = 'Ακύρωση';
 $_MODULE['<{mollie}prestashop>payment_334721e5f1ee825da687fcaede010724'] = 'Χρέωση Πληρωμής:';
 $_MODULE['<{mollie}prestashop>mollie_awaiting_order_status_error_56ce2a4e08c9d84441b90ab4c4b66f84'] = 'Επιλέξτε μια κατάσταση παραγγελίας για \"Κατάσταση για Πληρωμές σε αναμονή\" στην καρτέλα \"Προχωρημένες ρυθμίσεις\"';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'Προβολή στο Mollie';
 $_MODULE['<{mollie}prestashop>order_info_729a51874fe901b092899e9e8b31c97a'] = 'Είστε σίγουρος;';
 $_MODULE['<{mollie}prestashop>order_info_ccaf4ee393d094ecde7f21b15fdf8f1f'] = 'Είστε σίγουρος ότι θέλετε να λάβετε επιστροφή χρημάτων για αυτήν την παραγγελία;';
 $_MODULE['<{mollie}prestashop>order_info_76f0ed934de85cc7131910b32ede7714'] = 'Επιστροφή χρημάτων';
@@ -412,6 +413,7 @@
 $_MODULE['<{mollie}prestashop>mailservice_ed13b3693357ebed3751cb71cb639e65'] = 'Δεν υπάρχει μεταφορέας';
 $_MODULE['<{mollie}prestashop>mailservice_fca7e8d1c86db11246e429e40aa10c81'] = 'Νέο κουπόνι για την παραγγελία σας %s';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'Θα ξαναστείλετε email με τον σύνδεσμο πληρωμής στον πελάτη';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'Προβολή στο Mollie';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'Θα ξαναστείλετε email με τον σύνδεσμο πληρωμής στον πελάτη';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Επαναποστολή συνδέσμου πληρωμής';
 

translations/en.php

@@ -397,6 +397,7 @@
 $_MODULE['<{mollie}prestashop>mollie_iframe_fc7775bdfa339217149389b7392af83b'] = 'Save card';
 $_MODULE['<{mollie}prestashop>mollie_iframe_ee2b8214cd8479d18e873181505b48ea'] = 'Use saved card';
 $_MODULE['<{mollie}prestashop>mollie_iframe_49753ba0559e716a708373951ea87d1c'] = 'Secure payments provided by';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'View in Mollie';
 $_MODULE['<{mollie}prestashop>order_info_bcd372e1d75ca10ce207ef3ef14379d1'] = 'No products are available for this order because it was placed before Mollie version 6.4.1. You can still use the refund, capture, or ship actions.';
 $_MODULE['<{mollie}prestashop>order_info_81f04888e2363d334eeee1d13885509d'] = 'Refund amount (Max: %s)';
 $_MODULE['<{mollie}prestashop>order_info_88b6563ca5cac4845361c28959c5612e'] = 'Initiate Refund';
@@ -442,6 +443,7 @@
 $_MODULE['<{mollie}prestashop>installer_77240e73b3e9b64c47052880f87b6a8b'] = 'Unable to install voucher attributes';
 $_MODULE['<{mollie}prestashop>installer_407748408f99fed49e067dee67df619c'] = 'Could not copy email templates:';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'You will resend email with payment link to the customer';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'View in Mollie';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'You will resend email with payment link to the customer';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Resend payment link';
 $_MODULE['<{mollie}prestashop>paymentfeeprovider_a1fa8d7a9942f24895492dcaf7f3e16d'] = 'Discount: %1s';

translations/es.php

@@ -421,6 +421,7 @@
 $_MODULE['<{mollie}prestashop>mollie_iframe_fc7775bdfa339217149389b7392af83b'] = 'Guardar tarjeta';
 $_MODULE['<{mollie}prestashop>mollie_iframe_ee2b8214cd8479d18e873181505b48ea'] = 'Usar tarjeta guardada';
 $_MODULE['<{mollie}prestashop>mollie_iframe_49753ba0559e716a708373951ea87d1c'] = 'Pago seguro gestionado por';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'Ver en Mollie';
 $_MODULE['<{mollie}prestashop>order_info_bcd372e1d75ca10ce207ef3ef14379d1'] = 'No hay productos disponibles para este pedido porque fue realizado antes de la versión 6.4.1 de Mollie. Aún puedes usar las acciones de reembolso, captura o envío.';
 $_MODULE['<{mollie}prestashop>order_info_81f04888e2363d334eeee1d13885509d'] = 'Importe del reembolso (Máx.: %s)';
 $_MODULE['<{mollie}prestashop>order_info_88b6563ca5cac4845361c28959c5612e'] = 'Iniciar reembolso';
@@ -466,6 +467,7 @@
 $_MODULE['<{mollie}prestashop>installer_77240e73b3e9b64c47052880f87b6a8b'] = 'No se pueden instalar los atributos del vale';
 $_MODULE['<{mollie}prestashop>installer_407748408f99fed49e067dee67df619c'] = 'No ha sido posible copiar las plantillas de correo electrónico:';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'Se volverá a enviar el correo con el enlace de pago al cliente';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'Ver en Mollie';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'Se volverá a enviar el correo con el enlace de pago al cliente';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Reenviar enlace de pago';
 $_MODULE['<{mollie}prestashop>paymentfeeprovider_a1fa8d7a9942f24895492dcaf7f3e16d'] = 'Descuento: %1s';

translations/et.php

@@ -43,6 +43,7 @@
 $_MODULE['<{mollie}prestashop>qr_code_ea4788705e6873b424c65e91c2846b19'] = 'Tühista';
 $_MODULE['<{mollie}prestashop>payment_334721e5f1ee825da687fcaede010724'] = 'Maksetasu:';
 $_MODULE['<{mollie}prestashop>mollie_awaiting_order_status_error_56ce2a4e08c9d84441b90ab4c4b66f84'] = 'Vali tellimuse staatuseks "Ootel maksed" vahekaardil "Täpsemad seaded"';
+$_MODULE['<{mollie}prestashop>order_info_37d847d86227ba49e594d80112c74afa'] = 'Vaata Mollies';
 $_MODULE['<{mollie}prestashop>order_info_729a51874fe901b092899e9e8b31c97a'] = 'Kas oled kindel?';
 $_MODULE['<{mollie}prestashop>order_info_ccaf4ee393d094ecde7f21b15fdf8f1f'] = 'Kas oled kindel, et soovid selle tellimuse tagasimaksta?';
 $_MODULE['<{mollie}prestashop>order_info_76f0ed934de85cc7131910b32ede7714'] = 'Tagasimakse';
@@ -412,6 +413,7 @@
 $_MODULE['<{mollie}prestashop>mailservice_ed13b3693357ebed3751cb71cb639e65'] = 'Kandjat ei ole';
 $_MODULE['<{mollie}prestashop>mailservice_fca7e8d1c86db11246e429e40aa10c81'] = 'Uus kinkekaart sinu tellimusele %s';
 $_MODULE['<{mollie}prestashop>orderlistactionbuilder_5678cf484b844064515349752b1ccb18'] = 'Sa saadad kliendile uuesti e-maili makselingi saatmiseks';
+$_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_37d847d86227ba49e594d80112c74afa'] = 'Vaata Mollies';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_5678cf484b844064515349752b1ccb18'] = 'Sa saadad kliendile uuesti e-maili makselingi saatmiseks';
 $_MODULE['<{mollie}prestashop>ordergriddefinitionmodifier_74873b96b26fbcac6af3154c5dea0656'] = 'Saada makselink uuesti';