Merge pull request #201 from mollie/feature/MOL-895/shared-payment-custom-type

refactor(MOL-895): shared payment custom type

Author: Tung-Huynh-Shopmacher

CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## v1.4.5
+
+Added
+
+- Support for shared payment custom type (MOL-895)
+
+Changed
+
+- Reduced code complexity for surcharge logic
+
 ## v1.4.4
 
 Fixed

connect.yaml

@@ -30,6 +30,12 @@ deployAs:
         - key: CTP_TRANSACTION_CUSTOM_TYPE_KEY
           description: Custom type key for transactions in commercetools
           required: false
+        - key: CTP_PAYMENT_CUSTOM_TYPE_KEY
+          description: Custom type key for payments in commercetools
+          required: false
+        - key: CTP_INTERFACE_INTERACTION_CUSTOM_TYPE_KEY
+          description: Custom type key for payment interface interactions in commercetools
+          required: false
       securedConfiguration:
         - key: MOLLIE_API_TEST_KEY
           description: Mollie PSP test API key

processor/.env.example

@@ -28,10 +28,18 @@ MOLLIE_API_TEST_KEY=<YOUR_MOLLIE_API_TEST_KEY>
 MOLLIE_API_LIVE_KEY=<YOUR_MOLLIE_API_LIVE_KEY>
 MOLLIE_PROFILE_ID=<YOUR_MOLLIE_PROFILE_ID>
 
-## NGROK - only required for development
+## ngrok authtoken - only required for development for testing Mollie webhook; used at processor/bin/ngrok.sh
 CONNECTOR_EXTENSION_TOKEN=<YOUR_NGROK_AUTH_TOKEN>
 
 ## IF you have assigned a custom type to the transaction, you can specify it here
 ### So that the processor can use it to update the type adding its new fields
 ## If you have not assigned a custom type, you can leave this empty
-CTP_TRANSACTION_CUSTOM_TYPE_KEY=<your-current-transaction-custom-type-key>
+CTP_TRANSACTION_CUSTOM_TYPE_KEY=<YOUR_CURRENT_TRANSACTION_CUSTOM_TYPE_KEY>
+## IF you have assigned a custom type to the payment, you can specify it here
+### So that the processor can use it to update the type adding its new fields
+## If you have not assigned a custom type, you can leave this empty
+CTP_PAYMENT_CUSTOM_TYPE_KEY=<YOUR_CURRENT_PAYMENT_CUSTOM_TYPE_KEY>
+## IF you have assigned a custom type to the payment interface interaction, you can specify it here
+### So that the processor can use it to update the type adding its new fields
+## If you have not assigned a custom type, you can leave this empty
+CTP_INTERFACE_INTERACTION_CUSTOM_TYPE_KEY=<YOUR_CURRENT_INTERFACE_INTERACTION_CUSTOM_TYPE_KEY>

processor/package.json

@@ -1,7 +1,7 @@
 {
   "name": "shopmacher-mollie-processor",
   "description": "Integration between commercetools and mollie payment service provider",
-  "version": "1.4.4",
+  "version": "1.4.5",
   "main": "index.js",
   "private": true,
   "scripts": {