Problem
The oro/commerce dependency constraint does not match the actual OroCommerce version that each branch targets:
| Branch |
Version |
oro/commerce constraint |
Actual target |
master |
6.1.0 |
>=5.0 |
OroCommerce 6.1 |
5.0 |
5.2.3 |
^5.0 |
OroCommerce 5.0 |
On master, the constraint >=5.0 would allow Composer to install mollie/orocommerce 6.1.0 into an OroCommerce 5.0 environment, even though the code is not compatible with OroCommerce 5.x (it targets 6.x APIs and behavior).
Conversely, nothing prevents a future OroCommerce 7.x from pulling in this version, despite potentially breaking API changes.
Suggested Fix
Constrain the dependency to the major version each branch actually targets:
This follows standard Composer versioning best practices and prevents accidental cross-version installation.
Environment
- mollie/orocommerce: 6.1.0 (
master), 6.0 and 5.2.3 (5.0)
Problem
The
oro/commercedependency constraint does not match the actual OroCommerce version that each branch targets:oro/commerceconstraintmaster>=5.05.0^5.0On
master, the constraint>=5.0would allow Composer to installmollie/orocommerce6.1.0 into an OroCommerce 5.0 environment, even though the code is not compatible with OroCommerce 5.x (it targets 6.x APIs and behavior).Conversely, nothing prevents a future OroCommerce 7.x from pulling in this version, despite potentially breaking API changes.
Suggested Fix
Constrain the dependency to the major version each branch actually targets:
master(6.1):"oro/commerce": "~6.1"6.0branch:"oro/commerce": "~6.0"5.0branch:"oro/commerce": "~5.0"5.1branch with"oro/commerce": "~5.1"(e.g. for Surcharges not shown in checkout: instanceof MollieSurchargeAwareInterface fails for entity proxies #55)This follows standard Composer versioning best practices and prevents accidental cross-version installation.
Environment
master), 6.0 and 5.2.3 (5.0)