Skip to content

Commit c50cfe6

Browse files
authored
Merge pull request #9 from monkut/fix/add-columns-column-arg-fix
fixing bug in add_colums creation. Aligning to accept a list of colu…
2 parents 7437d32 + da3e41c commit c50cfe6

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

ghorgs/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '0.2.3'
1+
__version__ = '0.2.4'

ghorgs/managers.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import json
77
import uuid
88
import logging
9-
from typing import Tuple, List, Generator
9+
from typing import Tuple, List, Generator, Optional
1010
from functools import lru_cache
1111

1212
import requests
@@ -60,7 +60,7 @@ def _get_owner_id(self, name: str) -> str:
6060
raise UnexpectedResponseError(e.args)
6161
return org_id
6262

63-
def create_organizational_project(self, name: str, description: str, columns: list =None) -> Tuple[str, List[object]]:
63+
def create_organizational_project(self, name: str, description: str, columns: Optional[list]=None) -> Tuple[str, List[object]]:
6464
"""
6565
Create an Organizational Project in github
6666
@@ -74,8 +74,8 @@ def create_organizational_project(self, name: str, description: str, columns: li
7474
.. code:: python
7575
7676
[
77-
{'name': COLUMN_NAME},
78-
{'name': COLUMN_NAME},
77+
COLUMN_NAME,
78+
COLUMN_NAME
7979
]
8080
8181
:return:
@@ -131,7 +131,7 @@ def create_organizational_project(self, name: str, description: str, columns: li
131131

132132
return project_url, responses
133133

134-
def add_columns(self, project_id: str, columns: List[dict]) -> List:
134+
def add_columns(self, project_id: str, columns: List[str]) -> List:
135135
"""
136136
Add column(s) to the given project.
137137
@@ -144,7 +144,7 @@ def add_columns(self, project_id: str, columns: List[dict]) -> List:
144144
145145
"""
146146
addcolumns_responses = []
147-
for column_definition in columns:
147+
for column_name in columns:
148148
mutation_id = str(uuid.uuid4()) # get a random id
149149
graphql_addprojectcolumn = """
150150
mutation {
@@ -157,7 +157,7 @@ def add_columns(self, project_id: str, columns: List[dict]) -> List:
157157
}
158158
}
159159
}
160-
}""" % {'name': column_definition['name'],
160+
}""" % {'name': column_name,
161161
'project_id': project_id,
162162
'mutation_id': mutation_id}
163163

0 commit comments

Comments
 (0)