chore: adjust api

Author: peter-jerry-ye

src/websocket/client.mbt

@@ -112,7 +112,10 @@ pub async fn Client::send_binary(self : Client, data : Bytes) -> Unit {
 
 ///|
 /// Send a ping frame
-pub async fn Client::ping(self : Client, data? : Bytes = Bytes::new(0)) -> Unit {
+/// 
+/// TODO : it should be able to return a boolean 
+/// indicating if a pong was received within a timeout
+async fn Client::_ping(self : Client, data? : Bytes = Bytes::new(0)) -> Unit {
   if self.closed is Some(code) {
     raise ConnectionClosed(code)
   }
@@ -121,7 +124,9 @@ pub async fn Client::ping(self : Client, data? : Bytes = Bytes::new(0)) -> Unit
 
 ///|
 /// Send a pong frame
-pub async fn Client::pong(self : Client, data? : Bytes = Bytes::new(0)) -> Unit {
+/// 
+/// This is done automatically, so it is not exposed in the public API
+async fn Client::pong(self : Client, data? : Bytes = Bytes::new(0)) -> Unit {
   if self.closed is Some(code) {
     raise ConnectionClosed(code)
   }

src/websocket/frame.mbt

@@ -80,7 +80,7 @@ async fn[W : @io.Writer] write_frame(
   writer : W,
   fin : Bool,
   opcode : OpCode,
-  payload : Bytes,
+  payload : BytesView,
   masked : Bool,
 ) -> Unit {
   let payload_len = payload.length().to_int64()
@@ -127,7 +127,7 @@ async fn[W : @io.Writer] write_frame(
     }
     let payload_arr = payload.to_fixedarray()
     mask_payload(payload_arr, mask)
-    payload_arr.unsafe_reinterpret_as_bytes()
+    payload_arr.unsafe_reinterpret_as_bytes()[:]
   } else {
     payload
   }

src/websocket/pkg.generated.mbti

@@ -20,8 +20,6 @@ impl Show for WebSocketError
 type Client
 fn Client::close(Self) -> Unit
 async fn Client::connect(String, String, port? : Int, headers? : Map[String, String]) -> Self
-async fn Client::ping(Self, data? : Bytes) -> Unit
-async fn Client::pong(Self, data? : Bytes) -> Unit
 async fn Client::receive(Self) -> Message
 async fn Client::send_binary(Self, Bytes) -> Unit
 async fn Client::send_text(Self, String) -> Unit
@@ -31,6 +29,7 @@ pub(all) enum CloseCode {
   GoingAway
   ProtocolError
   UnsupportedData
+  Abnormal
   InvalidFramePayload
   PolicyViolation
   MessageTooBig
@@ -47,12 +46,10 @@ impl Show for Message
 
 type ServerConnection
 fn ServerConnection::close(Self) -> Unit
-async fn ServerConnection::ping(Self, data? : Bytes) -> Unit
-async fn ServerConnection::pong(Self, data? : Bytes) -> Unit
 async fn ServerConnection::receive(Self) -> Message
-async fn ServerConnection::send_binary(Self, Bytes) -> Unit
-async fn ServerConnection::send_close(Self, code? : CloseCode, reason? : String) -> Unit
-async fn ServerConnection::send_text(Self, String) -> Unit
+async fn ServerConnection::send_binary(Self, BytesView) -> Unit
+async fn ServerConnection::send_close(Self, code? : CloseCode, reason? : BytesView) -> Unit
+async fn ServerConnection::send_text(Self, StringView) -> Unit
 
 // Type aliases
 

src/websocket/server.mbt

@@ -110,7 +110,7 @@ pub fn ServerConnection::close(self : ServerConnection) -> Unit {
 /// Send a text message
 pub async fn ServerConnection::send_text(
   self : ServerConnection,
-  text : String,
+  text : StringView,
 ) -> Unit {
   if self.closed is Some(code) {
     raise ConnectionClosed(code)
@@ -123,7 +123,7 @@ pub async fn ServerConnection::send_text(
 /// Send a binary message
 pub async fn ServerConnection::send_binary(
   self : ServerConnection,
-  data : Bytes,
+  data : BytesView,
 ) -> Unit {
   if self.closed is Some(code) {
     raise ConnectionClosed(code)
@@ -133,7 +133,10 @@ pub async fn ServerConnection::send_binary(
 
 ///|
 /// Send a ping frame
-pub async fn ServerConnection::ping(
+/// 
+/// TODO : it should be able to return a boolean 
+/// indicating if a pong was received within a timeout
+async fn ServerConnection::_ping(
   self : ServerConnection,
   data? : Bytes = Bytes::new(0),
 ) -> Unit {
@@ -145,7 +148,9 @@ pub async fn ServerConnection::ping(
 
 ///|
 /// Send a pong frame
-pub async fn ServerConnection::pong(
+/// 
+/// It is done automatically, so it is not exposed in the public API
+async fn ServerConnection::pong(
   self : ServerConnection,
   data? : Bytes = Bytes::new(0),
 ) -> Unit {