fix: address Copilot code review feedback (#268)

Author: moshfeu

.vscode/settings.json

@@ -8,5 +8,5 @@
   },
   // Turn off tsc task auto detection since we have the necessary tasks as npm scripts
   "typescript.tsc.autoDetect": "off",
-  "i18n-ally.localesPaths": ["src/locales"]
+  "i18n-ally.localesPaths": ["l10n"]
 }

package.json

@@ -527,7 +527,7 @@
     "@types/mocha": "^10.0.1",
     "@types/node": "^20.0.0",
     "@types/sinon": "^10.0.13",
-    "@types/vscode": "^1.110.0",
+    "@types/vscode": "1.73.1",
     "@vscode/l10n-dev": "^0.0.35",
     "@vscode/test-electron": "^2.3.8",
     "dotenv": "^8.2.0",

package.nls.json

@@ -11,14 +11,14 @@
   "ext.config.ignoreAllWhiteSpaces.description": "Ignore all white space differences (similar to 'diff -w')",
   "ext.config.ignoreEmptyLines.description": "Ignore differences caused by empty lines (similar to 'diff -B')",
   "ext.config.ignoreFileNameCase.description": "If true fileName / FileName / FiLE naMe will consider as same file and will be compared",
-  "ext.config.ignoreExtension.description": "Pairs of extensions to to considered the same file (.e.g [index.js, index.ts]). Each extension can appear **only once**",
+  "ext.config.ignoreExtension.description": "Pairs of extensions to be considered the same file (e.g. [index.js, index.ts]). Each extension can appear **only once**",
   "ext.config.includeFilter.description": "Include filters",
   "ext.config.excludeFilter.description": "Exclude filters",
   "ext.config.respectGitIgnore.description": "Include / Exclude files based on .gitignore",
   "ext.config.diffViewTitle.enum.nameOnly": "eg. file-name.txt",
   "ext.config.diffViewTitle.enum.comparedPath": "eg. file-name.txt ↔ path/to/compared/file-name.txt",
   "ext.config.diffViewTitle.enum.fullPath": "eg. c://file-name.txt ↔ c://path/to/compared/file-name.txt",
-  "ext.config.diffViewTitle.description": "Specifies how the diff view's title look like",
+  "ext.config.diffViewTitle.description": "Specifies how the diff view's title looks",
   "ext.config.diffLayout.enum.localCompared": "eg. left: local file, right: compared file",
   "ext.config.diffLayout.enum.comparedLocal": "eg. left: compared file, right: local file",
   "ext.config.diffLayout.description": "Specifies which file will be in the left and the right sides of the diff view",

scripts/validate-l10n.js

@@ -165,10 +165,10 @@ function showExtractedStrings() {
 function checkHardcodedStrings() {
   console.log('🔎 Checking for hardcoded user-facing strings...\n');
 
-  const glob = require('child_process').execSync(
-    'find ./src -name "*.ts" -not -path "*/test/*"',
-    { encoding: 'utf8' }
-  ).trim().split('\n').filter(Boolean);
+  const glob = require('glob');
+  const files = glob.sync('./src/**/*.ts', {
+    ignore: ['**/test/**', '**/**.test.ts']
+  });
 
   const suspiciousPatterns = [
     // UI message functions with string literals (not using l10n.t)
@@ -182,7 +182,7 @@ function checkHardcodedStrings() {
 
   const issues = [];
 
-  glob.forEach(file => {
+  files.forEach(file => {
     const content = fs.readFileSync(file, 'utf8');
     const lines = content.split('\n');
 

src/providers/foldersCompareProvider.ts

@@ -366,12 +366,6 @@ export class CompareFoldersProvider extends BaseViewProvider {
   }
 }
 
-console.log(
-  l10n.bundle,
-  l10n.uri,
-  l10n.t('Click to select folders'),
-)
-
 const openFolderChild = (isSingle: boolean) =>
   new File({
     label: isSingle ? l10n.t('Click to select a folder') : l10n.t('Click to select folders'),

src/test/suite/mocks/treeView.ts

@@ -1,7 +1,6 @@
 import {
   EventEmitter,
   type Event,
-  type TreeCheckboxChangeEvent,
   type TreeView,
   type TreeViewExpansionEvent,
   type TreeViewSelectionChangeEvent,
@@ -21,8 +20,6 @@ export class MockTreeView implements TreeView<File> {
   readonly onDidCollapseElement: Event<TreeViewExpansionEvent<File>> = new EventEmitter<TreeViewExpansionEvent<File>>().event;
   readonly onDidChangeSelection: Event<TreeViewSelectionChangeEvent<File>> = new EventEmitter<TreeViewSelectionChangeEvent<File>>().event;
   readonly onDidChangeVisibility: Event<TreeViewVisibilityChangeEvent> = new EventEmitter<TreeViewVisibilityChangeEvent>().event;
-  readonly onDidChangeCheckboxState: Event<TreeCheckboxChangeEvent<File>> = new EventEmitter<TreeCheckboxChangeEvent<File>>().event;
-
   reveal(): Thenable<void> {
     return Promise.resolve();
   }

yarn.lock

@@ -240,10 +240,10 @@
   resolved "https://registry.npmjs.org/@types/sinonjs__fake-timers/-/sinonjs__fake-timers-8.1.5.tgz"
   integrity sha512-mQkU2jY8jJEF7YHjHvsQO8+3ughTL1mcnn96igfhONmR+fUPSKIkefQYpSe8bsly2Ep7oQbn/6VG5/9/0qcArQ==
 
-"@types/vscode@^1.110.0":
-  version "1.110.0"
-  resolved "https://registry.npmjs.org/@types/vscode/-/vscode-1.110.0.tgz"
-  integrity sha512-AGuxUEpU4F4mfuQjxPPaQVyuOMhs+VT/xRok1jiHVBubHK7lBRvCuOMZG0LKUwxncrPorJ5qq/uil3IdZBd5lA==
+"@types/vscode@1.73.1":
+  version "1.73.1"
+  resolved "https://registry.npmjs.org/@types/vscode/-/vscode-1.73.1.tgz"
+  integrity sha512-eArfOrAoZVV+Ao9zQOCaFNaeXj4kTCD+bGS2gyNgIFZH9xVMuLMlRrEkhb22NyxycFWKV1UyTh03vhaVHmqVMg==
 
 "@typespec/ts-http-runtime@^0.3.0", "@typespec/ts-http-runtime@^0.3.4":
   version "0.3.4"