fix: resolve cppcheck memleakOnRealloc and constParameterPointer warnings

Made-with: Cursor

Author: mr-light-show

src/main.c

@@ -109,7 +109,7 @@ static bool BarMainLoginUser (BarApp_t *app) {
 /*	Run a password_command and return the result, or NULL on failure.
  *	Caller must free the returned string.
  */
-static char *BarRunPasswordCommand (BarSettings_t *settings, const char *cmd) {
+static char *BarRunPasswordCommand (const BarSettings_t *settings, const char *cmd) {
 	pid_t chld;
 	int pipeFd[2];
 	char passBuf[BAR_INPUT_MAX];
@@ -166,7 +166,7 @@ static char *BarRunPasswordCommand (BarSettings_t *settings, const char *cmd) {
  *	Sets acct->password if password_command succeeds.
  *	@return true if password is available after resolution.
  */
-static bool BarResolveAccountPassword (BarSettings_t *settings, BarAccount_t *acct) {
+static bool BarResolveAccountPassword (const BarSettings_t *settings, BarAccount_t *acct) {
 	if (acct->password != NULL) return true;
 	if (acct->passwordCmd != NULL) {
 		acct->password = BarRunPasswordCommand (settings, acct->passwordCmd);

src/settings.c

@@ -771,11 +771,18 @@ void BarSettingsRead (BarSettings_t *settings) {
 			char *colon = strchr (val, ':');
 			if (colon && colon != val && *(colon + 1) != '\0') {
 				*colon = '\0';
-				accountLines = realloc (accountLines,
+				BarAccountLine_t *newLines = realloc (accountLines,
 						(accountLineCount + 1) * sizeof (BarAccountLine_t));
-				accountLines[accountLineCount].id = strdup (val);
-				accountLines[accountLineCount].path = strdup (colon + 1);
-				accountLineCount++;
+				if (newLines == NULL) {
+					BarUiMsg (settings, MSG_ERR,
+							"Out of memory reading account lines at %s:%zu\n",
+							path, lineNum);
+				} else {
+					accountLines = newLines;
+					accountLines[accountLineCount].id = strdup (val);
+					accountLines[accountLineCount].path = strdup (colon + 1);
+					accountLineCount++;
+				}
 			} else {
 				BarUiMsg (settings, MSG_INFO,
 						"Invalid account format at %s:%zu (expected id:path)\n",