Merge pull request #118 from mrodrig/fix-117

Fix 117

Author: mrodrig

package-lock.json

@@ -5,7 +5,7 @@
     },
     "name": "json-2-csv",
     "description": "A JSON to CSV and CSV to JSON converter that natively supports sub-documents and auto-generates the CSV heading.",
-    "version": "3.5.1",
+    "version": "3.5.2",
     "repository": {
         "type": "git",
         "url": "https://github.com/mrodrig/json-2-csv.git"

package.json

@@ -14,7 +14,8 @@ const Csv2Json = function(options) {
      * @param headerKey
      * @returns {*}
      */
-    function trimHeaderKey(headerKey) {
+    function processHeaderKey(headerKey) {
+        headerKey = removeWrapDelimitersFromValue(headerKey);
         if (options.trimHeaderFields) {
             return headerKey.split('.')
                 .map((component) => component.trim())
@@ -33,7 +34,7 @@ const Csv2Json = function(options) {
             // Generate and return the heading keys
             headerRow = params.lines[0];
         params.headerFields = headerRow.map((headerKey, index) => ({
-            value: trimHeaderKey(headerKey),
+            value: processHeaderKey(headerKey),
             index: index
         }));
 

src/csv2json.js

@@ -27,6 +27,7 @@ const fs = require('fs'),
         {key: 'noHeader', file: '../data/csv/noHeader.csv'},
         {key: 'sortedHeader', file: '../data/csv/sortedHeader.csv'},
         {key: 'emptyFieldValues', file: '../data/csv/emptyFieldValues.csv'},
+        {key: 'quotedEmptyFieldValue', file: '../data/csv/quotedEmptyFieldValue.csv'},
         {key: 'csvEmptyLastValue', file: '../data/csv/csvEmptyLastValue.csv'}
     ];
 

test/config/testCsvFilesList.js

@@ -20,5 +20,6 @@ module.exports = {
     trimmedHeader: require('../data/json/trimmedHeader'),
     specifiedKeys: require('../data/json/specifiedKeys'),
     emptyFieldValues: require('../data/json/emptyFieldValues'),
+    quotedEmptyFieldValue: require('../data/json/quotedEmptyFieldValue'),
     csvEmptyLastValue: require('../data/json/csvEmptyLastValue')
 };

test/config/testJsonFilesList.js

@@ -153,6 +153,15 @@ function runTests(jsonTestData, csvTestData) {
                     done();
                 });
             });
+
+            // Test case for #115
+            it('should properly handle quoted empty field values', (done) => {
+                converter.csv2json(csvTestData.quotedEmptyFieldValue, (err, json) => {
+                    if (err) done(err);
+                    json.should.deepEqual(jsonTestData.quotedEmptyFieldValue);
+                    done();
+                });
+            });
         });
 
         describe('Error Handling', () => {

test/csv2json.js

@@ -0,0 +1,2 @@
+"a","b","c"
+"foo","","bar"

test/data/csv/quotedEmptyFieldValue.csv

@@ -0,0 +1,7 @@
+[
+  {
+    "a": "foo",
+    "b": "",
+    "c": "bar"
+  }
+]