Skip to content

Commit 819807f

Browse files
[core] Fix internal version duplication (#46051)
Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Jan Potoms <[email protected]>
1 parent 80d9ec4 commit 819807f

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

docs/next.config.ts

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,13 @@ export default withDocsInfra({
4343
);
4444
}
4545

46-
// next includes node_modules in webpack externals. Some of those have dependencies
47-
// on the aliases defined above. If a module is an external those aliases won't be used.
48-
// We need tell webpack to not consider those packages as externals.
46+
// If a module is an webpack "external" the webpack aliases configured are not used.
47+
// Next.js includes node_modules in webpack externals, some of those have dependencies
48+
// on the aliases we defined above.
49+
// So we need tell webpack to not consider those packages as externals.
4950
if (
5051
options.isServer &&
51-
// Next executes this twice on the server with React 18 (once per runtime).
52+
// Next.js executes this twice on the server with React 18 (once per runtime).
5253
// We only care about Node runtime at this point.
5354
(options.nextRuntime === undefined || options.nextRuntime === 'nodejs')
5455
) {
@@ -60,15 +61,9 @@ export default withDocsInfra({
6061
(ctx, callback) => {
6162
const { request } = ctx;
6263
const hasDependencyOnRepoPackages = [
63-
'notistack',
64-
'@mui/x-data-grid',
65-
'@mui/x-data-grid-pro',
66-
'@mui/x-date-pickers',
67-
'@mui/x-date-pickers-pro',
68-
'@mui/x-data-grid-generator',
69-
'@mui/x-charts',
70-
'@mui/x-tree-view',
71-
'@mui/x-license-pro',
64+
'material-ui-popup-state',
65+
// Assume any X dependencies depend on a package defined in this repository.
66+
'@mui/x-',
7267
'@toolpad/core',
7368
].some((dep) => request.startsWith(dep));
7469

0 commit comments

Comments
 (0)