[TextareaAutosize] Prevent placeholder from affecting height #46556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46556--material-ui.netlify.app/ Bundle size report
|
|
Dear @ZeeshanTamboli and @mj12albert, could you please review this PR? Thanks |
Mohammadreza-Sarvari
force-pushed
the
fix/text-area-auto-size-placeholder
branch
from
8f93d36 to
08ab634
Compare
Mohammadreza-Sarvari
force-pushed
the
fix/text-area-auto-size-placeholder
branch
from
08ab634 to
6d3b316
Compare
There was a problem hiding this comment.
@Mohammadreza-Sarvari Thanks for the PR. But I misunderstood the issue earlier. See #46543 (comment). I think the fix is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #46543
Summary:
TextareaAutosize ignores placeholder text when measuring height for auto-resize and ensures long placeholders do not cause unintended row expansion.
Before:
before.mov
After:
after.mov