Skip to content

Commit 0f41d3b

Browse files
[Coverage] Don't produce a JUnit report.
The `unittest` binary crashes with ``` unittest: /var/lib/gitlab-runner/builds/yS6csq8A/0/bigdata/mutable/mutable/third-party/catch2/include/catch2/catch.hpp:5918: virtual void Catch::CumulativeReporterBase<Catch::JunitReporter>::testCaseEnded(const Catch::TestCaseStats &) [DerivedT = Catch::JunitReporter]: Assertion `m_sectionStack.size() == 0' failed. ``` This error seems to be related to the Catch 2 JUnit reporter. See catchorg/Catch2#1801 and catchorg/Catch2#1967. To remedy this problem, we simply don't use produce a report anymore. It was never used, anyway.
1 parent f2ff37b commit 0f41d3b

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

.gitlab-ci.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -402,11 +402,6 @@ report:coverage:
402402
- .coverage
403403
- .shared
404404
- .build_cache
405-
artifacts:
406-
paths:
407-
- "build/${BUILD_TYPE}/catch.xml"
408-
reports:
409-
junit: "build/${BUILD_TYPE}/catch.xml"
410405
rules:
411406
- if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
412407
when: on_success
@@ -600,4 +595,4 @@ publish:github-release:
600595
-H "X-GitHub-Api-Version: 2022-11-28"
601596
-H "Content-Type: application/octet-stream"
602597
"${upload_url}?name=mutable-macos-amd64-${TAG}.zip"
603-
--data-binary "@mutable/mutable-macos-amd64.zip"
598+
--data-binary "@mutable/mutable-macos-amd64.zip"

coverage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ lcov ${LCOV_FLAGS} --zerocounters --directory src --directory unittest
5959
lcov ${LCOV_FLAGS} --capture --initial --directory src --directory unittest --output-file base.info
6060
# lcov ${LCOV_FLAGS} --capture --initial --output-file unittest.base
6161
# Run tests
62-
bin/unittest --durations yes --reporter junit --out catch.xml '[core]'
62+
bin/unittest --reporter compact '[core]'
6363
# Capture lcov counters and generate report
6464
lcov ${LCOV_FLAGS} --capture --directory src --directory unittest --output-file test.info
6565
# lcov ${LCOV_FLAGS} --capture --directory unittest --output-file unittest.capture

0 commit comments

Comments
 (0)