Add short descriptions to data generators

Author: skodak

tests/generator/lib.php

@@ -62,6 +62,9 @@ public function create_section($record = null): stdClass {
         if (!isset($record->name)) {
             $record->name = 'Section ' . $this->sectioncount;
         }
+        if (trim($record->shortdescription ?? '') === '') {
+            $record->shortdescription = 'Description of section ' . $record->name;
+        }
 
         return section::create($record);
     }
@@ -112,6 +115,9 @@ public function create_collection($record = null): stdClass {
         if (!isset($record->name)) {
             $record->name = 'Collection ' . $this->collectioncount;
         }
+        if (trim($record->shortdescription ?? '') === '') {
+            $record->shortdescription = 'Description of collection ' . $record->name;
+        }
 
         return collection::create($record);
     }

tests/phpunit/generator_test.php

@@ -55,6 +55,7 @@ public function test_create_section(): void {
         $this->setCurrentTimeStart();
         $section = $generator->create_section();
         $this->assertSame('Section 1', $section->name);
+        $this->assertSame('Description of section Section 1', $section->shortdescription);
         $this->assertSame((string)$syscontext->id, $section->contextid);
         $this->assertSame(null, $section->frontpagepriority);
         $this->assertSame((string)util::STATUS_ACTIVE, $section->status);
@@ -70,6 +71,7 @@ public function test_create_section(): void {
 
         $section = $generator->create_section([
             'name' => 'Some section',
+            'shortdescription' => 'Some desc',
             'contextid' => $categorycontext->id,
             'frontpagepriority' => '777',
             'status' => util::STATUS_DRAFT,
@@ -78,6 +80,7 @@ public function test_create_section(): void {
             'cohortvisible' => [$cohort1->id, $cohort2->id],
         ]);
         $this->assertSame('Some section', $section->name);
+        $this->assertSame('Some desc', $section->shortdescription);
         $this->assertSame('777', $section->frontpagepriority);
         $this->assertSame((string)util::STATUS_DRAFT, $section->status);
         $this->assertSame('1', $section->guestvisible);
@@ -183,6 +186,7 @@ public function test_create_collection(): void {
         $this->setCurrentTimeStart();
         $collection = $generator->create_collection();
         $this->assertSame('Collection 1', $collection->name);
+        $this->assertSame('Description of collection Collection 1', $collection->shortdescription);
         $this->assertSame((string)$syscontext->id, $collection->contextid);
         $this->assertSame(null, $collection->frontpagepriority);
         $this->assertSame('0', $collection->guestvisible);
@@ -197,13 +201,15 @@ public function test_create_collection(): void {
 
         $collection = $generator->create_collection([
             'name' => 'Some collection',
+            'shortdescription' => 'Some desc',
             'contextid' => $categorycontext->id,
             'frontpagepriority' => '777',
             'guestvisible' => 1,
             'uservisible' => 0,
             'cohortvisible' => [$cohort1->id, $cohort2->id],
         ]);
         $this->assertSame('Some collection', $collection->name);
+        $this->assertSame('Some desc', $collection->shortdescription);
         $this->assertSame('777', $collection->frontpagepriority);
         $this->assertSame('1', $collection->guestvisible);
         $this->assertSame('0', $collection->uservisible);