You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: Modified timeouts to address flaky tests (#1284)
Closesmuxinc/devextravaganza#216
Changes to try to reduce test flakiness for Webkit runs.
For example on:
https://github.com/muxinc/media-chrome/actions/runs/23017090932/job/66843131347
Also added a step to try to improve run time on job reruns, since they
sometimes take more than 20 mins
Before changes (`Run npx playwright install-deps` step) :
<img width="728" height="141" alt="image"
src="https://github.com/user-attachments/assets/9d866db3-29cc-4dfb-afeb-7dcf943accd5"
/>
After changes:
<img width="780" height="195" alt="image"
src="https://github.com/user-attachments/assets/8b3c280c-1b46-4207-af74-16a6237c96fa"
/>
Note: changes inspired by these two posts [microsoft/playwright -
[Question] Speed up installing browsers in GitHub
Actions](microsoft/playwright#14434) and
related [actions/runner - man-db trigger severely stalls package
installation on ubuntu-24.04 runners
#4030](actions/runner#4030)
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk: changes are limited to CI/CD workflow steps and test
timing/await logic; main risk is longer test timeouts potentially
masking legitimate hangs.
>
> **Overview**
> **Stabilizes Playwright-driven unit tests and speeds up GitHub Actions
runs.** CI and CD workflows now remove `man-db` before Playwright
dependency installs to reduce `apt` delays on Ubuntu runners.
>
> Updates flaky tests to rely on `waitUntil` (with longer per-suite
timeouts and explicit failure messages) instead of fixed `aTimeout`
sleeps, and adds `preload="auto"` to the test video fixture to make
state assertions more deterministic (notably on WebKit).
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
2aedbfd. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Manuel Calleriza <mcalleriza@mux.com>
0 commit comments