Improvements in PropertyChanged.Fody (#383)

josesimoes · web-flow · commit 1b5012bd6869 · 2024-11-27T14:02:15.000Z
diff --git a/nanoFramework.Tools.DebugLibrary.Net/nanoFramework.Tools.DebugLibrary.Net.csproj b/nanoFramework.Tools.DebugLibrary.Net/nanoFramework.Tools.DebugLibrary.Net.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+﻿<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <OutputType>library</OutputType>
     <TargetFrameworks>net6.0;net472</TargetFrameworks>
@@ -56,6 +56,11 @@
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
   </PropertyGroup>
+  <PropertyGroup>
+    <PropertyChangedAnalyzerConfiguration>
+      <IsCodeGeneratorDisabled>false</IsCodeGeneratorDisabled>
+    </PropertyChangedAnalyzerConfiguration>
+  </PropertyGroup>  
   <ItemGroup>
     <None Include="app.config" />
     <None Include="key.snk" />
@@ -84,6 +89,7 @@
     <PackageReference Include="Polly" Version="7.2.4" />
     <PackageReference Include="PropertyChanged.Fody">
       <Version>4.1.0</Version>
+      <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="System.IO.Ports">
       <Version>8.0.0</Version>
@@ -93,4 +99,4 @@
     <Content Include="FodyWeavers.xml" />
   </ItemGroup>
   <Import Project="..\nanoFramework.Tools.DebugLibrary.Shared\nanoFramework.Tools.DebugLibrary.Net.projitems" Label="Shared" />
-</Project>
+</Project>
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.NetworkConfigurationProperties.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.NetworkConfigurationProperties.cs
@@ -12,7 +12,7 @@ public partial class DeviceConfiguration
     {
         /////////////////////////////////////////////////////////////
 
-        public class NetworkConfigurationProperties : NetworkConfigurationPropertiesBase
+        public partial class NetworkConfigurationProperties : NetworkConfigurationPropertiesBase
         {
             internal const uint EmptySpecificConfigValue = uint.MaxValue;
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.Wireless80211ConfigurationProperties.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.Wireless80211ConfigurationProperties.cs
@@ -10,7 +10,7 @@ namespace nanoFramework.Tools.Debugger
 {
     public partial class DeviceConfiguration
     {
-        public class Wireless80211ConfigurationProperties : Wireless80211ConfigurationPropertiesBase
+        public partial class Wireless80211ConfigurationProperties : Wireless80211ConfigurationPropertiesBase
         {
             public bool IsUnknown { get; set; }
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.WirelessAPConfigurationProperties.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.WirelessAPConfigurationProperties.cs
@@ -10,7 +10,7 @@ namespace nanoFramework.Tools.Debugger
 {
     public partial class DeviceConfiguration
     {
-        public class WirelessAPConfigurationProperties : WirelessAPConfigurationPropertiesBase
+        public partial class WirelessAPConfigurationProperties : WirelessAPConfigurationPropertiesBase
         {
             public bool IsUnknown { get; set; }
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.X509CaRootBundleProperties.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.X509CaRootBundleProperties.cs
@@ -9,7 +9,7 @@ namespace nanoFramework.Tools.Debugger
 {
     public partial class DeviceConfiguration
     {
-        public class X509CaRootBundleProperties : X509CaRootBundlePropertiesBase
+        public partial class X509CaRootBundleProperties : X509CaRootBundlePropertiesBase
         {
             public bool IsUnknown { get; set; }
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.X509DeviceCertificatesProperties.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/DeviceConfiguration.X509DeviceCertificatesProperties.cs
@@ -9,7 +9,7 @@ namespace nanoFramework.Tools.Debugger
 {
     public partial class DeviceConfiguration
     {
-        public class X509DeviceCertificatesProperties : X509DeviceCertificatesPropertiesBase
+        public partial class X509DeviceCertificatesProperties : X509DeviceCertificatesPropertiesBase
         {
             public bool IsUnknown { get; set; }
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/NetworkConfigurationPropertiesBase.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/NetworkConfigurationPropertiesBase.cs
@@ -9,7 +9,7 @@
 namespace nanoFramework.Tools.Debugger
 {
     [AddINotifyPropertyChangedInterface]
-    public class NetworkConfigurationPropertiesBase
+    public partial class NetworkConfigurationPropertiesBase
     {
         public IPAddress IPv4Address { get; set; }
         public IPAddress IPv4DNSAddress1 { get; set; }
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/Wireless80211ConfigurationPropertiesBase.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/Wireless80211ConfigurationPropertiesBase.cs
@@ -8,7 +8,7 @@ namespace nanoFramework.Tools.Debugger
     /// <summary>
     /// Base class for wireless 802.11 configuration properties.
     /// </summary>
-    public class Wireless80211ConfigurationPropertiesBase : WirelessConfigurationPropertiesBase
+    public partial class Wireless80211ConfigurationPropertiesBase : WirelessConfigurationPropertiesBase
     {
         // No additional properties needed for now
     }
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/WirelessAPConfigurationPropertiesBase.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/WirelessAPConfigurationPropertiesBase.cs
@@ -8,7 +8,7 @@ namespace nanoFramework.Tools.Debugger
     /// <summary>
     /// Base class for wireless Access Point configuration properties.
     /// </summary>
-    public class WirelessAPConfigurationPropertiesBase : WirelessConfigurationPropertiesBase
+    public partial class WirelessAPConfigurationPropertiesBase : WirelessConfigurationPropertiesBase
     {
         /// <summary>
         /// Channel for the network.
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/WirelessConfigurationPropertiesBase.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/WirelessConfigurationPropertiesBase.cs
@@ -11,7 +11,7 @@ namespace nanoFramework.Tools.Debugger
     /// Base class for common wireless configuration properties.
     /// </summary>
     [AddINotifyPropertyChangedInterface]
-    public class WirelessConfigurationPropertiesBase
+    public partial class WirelessConfigurationPropertiesBase
     {
         /// <summary>
         /// Id of the configuration.
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/X509CaRootBundlePropertiesBase.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/X509CaRootBundlePropertiesBase.cs
@@ -8,7 +8,7 @@
 namespace nanoFramework.Tools.Debugger
 {
     [AddINotifyPropertyChangedInterface]
-    public class X509CaRootBundlePropertiesBase
+    public partial class X509CaRootBundlePropertiesBase
     {
         private byte[] _certificate;
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/X509DeviceCertificatesPropertiesBase.cs b/nanoFramework.Tools.DebugLibrary.Shared/DeviceConfiguration/X509DeviceCertificatesPropertiesBase.cs
@@ -8,7 +8,7 @@
 namespace nanoFramework.Tools.Debugger
 {
     [AddINotifyPropertyChangedInterface]
-    public class X509DeviceCertificatesPropertiesBase
+    public partial class X509DeviceCertificatesPropertiesBase
     {
         private byte[] _certificate;
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/NFDevice/NanoDevice.cs b/nanoFramework.Tools.DebugLibrary.Shared/NFDevice/NanoDevice.cs
@@ -10,7 +10,7 @@
 
 namespace nanoFramework.Tools.Debugger
 {
-    public class NanoDevice<T> : NanoDeviceBase, IDisposable, INanoDevice where T : new()
+    public partial class NanoDevice<T> : NanoDeviceBase, IDisposable, INanoDevice where T : new()
     {
         private bool _disposed;
 
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/NFDevice/NanoDeviceBase.cs b/nanoFramework.Tools.DebugLibrary.Shared/NFDevice/NanoDeviceBase.cs
@@ -18,7 +18,7 @@
 namespace nanoFramework.Tools.Debugger
 {
     [AddINotifyPropertyChangedInterface]
-    public abstract class NanoDeviceBase
+    public abstract partial class NanoDeviceBase
     {
         /// <summary>
         /// nanoFramework debug engine.
@@ -43,6 +43,7 @@ public abstract class NanoDeviceBase
         /// <summary>
         /// Device description.
         /// </summary>
+        [DependsOn(nameof(TargetName), nameof(ConnectionId))]
         public string Description => $"{TargetName} @ {ConnectionId}";
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public partial class DeviceConfiguration`
`12`	`12`	`{`
`13`	`13`	`/////////////////////////////////////////////////////////////`
`14`	`14`
`15`		`- public class NetworkConfigurationProperties : NetworkConfigurationPropertiesBase`
	`15`	`+ public partial class NetworkConfigurationProperties : NetworkConfigurationPropertiesBase`
`16`	`16`	`{`
`17`	`17`	`internal const uint EmptySpecificConfigValue = uint.MaxValue;`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace nanoFramework.Tools.Debugger`
`10`	`10`	`{`
`11`	`11`	`public partial class DeviceConfiguration`
`12`	`12`	`{`
`13`		`- public class Wireless80211ConfigurationProperties : Wireless80211ConfigurationPropertiesBase`
	`13`	`+ public partial class Wireless80211ConfigurationProperties : Wireless80211ConfigurationPropertiesBase`
`14`	`14`	`{`
`15`	`15`	`public bool IsUnknown { get; set; }`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace nanoFramework.Tools.Debugger`
`9`	`9`	`{`
`10`	`10`	`public partial class DeviceConfiguration`
`11`	`11`	`{`
`12`		`- public class X509CaRootBundleProperties : X509CaRootBundlePropertiesBase`
	`12`	`+ public partial class X509CaRootBundleProperties : X509CaRootBundlePropertiesBase`
`13`	`13`	`{`
`14`	`14`	`public bool IsUnknown { get; set; }`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`namespace nanoFramework.Tools.Debugger`
`10`	`10`	`{`
`11`	`11`	`[AddINotifyPropertyChangedInterface]`
`12`		`- public class NetworkConfigurationPropertiesBase`
	`12`	`+ public partial class NetworkConfigurationPropertiesBase`
`13`	`13`	`{`
`14`	`14`	`public IPAddress IPv4Address { get; set; }`
`15`	`15`	`public IPAddress IPv4DNSAddress1 { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ namespace nanoFramework.Tools.Debugger`
`8`	`8`	`/// <summary>`
`9`	`9`	`/// Base class for wireless 802.11 configuration properties.`
`10`	`10`	`/// </summary>`
`11`		`- public class Wireless80211ConfigurationPropertiesBase : WirelessConfigurationPropertiesBase`
	`11`	`+ public partial class Wireless80211ConfigurationPropertiesBase : WirelessConfigurationPropertiesBase`
`12`	`12`	`{`
`13`	`13`	`// No additional properties needed for now`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ namespace nanoFramework.Tools.Debugger`
`8`	`8`	`/// <summary>`
`9`	`9`	`/// Base class for wireless Access Point configuration properties.`
`10`	`10`	`/// </summary>`
`11`		`- public class WirelessAPConfigurationPropertiesBase : WirelessConfigurationPropertiesBase`
	`11`	`+ public partial class WirelessAPConfigurationPropertiesBase : WirelessConfigurationPropertiesBase`
`12`	`12`	`{`
`13`	`13`	`/// <summary>`
`14`	`14`	`/// Channel for the network.`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace nanoFramework.Tools.Debugger`
`11`	`11`	`/// Base class for common wireless configuration properties.`
`12`	`12`	`/// </summary>`
`13`	`13`	`[AddINotifyPropertyChangedInterface]`
`14`		`- public class WirelessConfigurationPropertiesBase`
	`14`	`+ public partial class WirelessConfigurationPropertiesBase`
`15`	`15`	`{`
`16`	`16`	`/// <summary>`
`17`	`17`	`/// Id of the configuration.`