Merge pull request #442 from nansen-ai/fix/research-reject-unsupported-flags

fix(research): reject --page/--limit and --sort on subcommands that don't support them

Author: kome12

.changeset/research-reject-unsupported-flags.md

@@ -0,0 +1,5 @@
+---
+"nansen-cli": patch
+---
+
+`research historical-token-flow-summary` now errors immediately when `--page` or `--limit` are passed (the endpoint returns a single aggregated row and does not support pagination). `research historical-smart-money-balances` now errors when `--sort` or `--order-by` are passed (the endpoint does not support ordering). Previously both flags were silently dropped.

src/__tests__/research.test.js

@@ -425,4 +425,18 @@ describe('buildResearchCommands handler', () => {
     await expect(cmds.research(['historical-token-screener'], mockApi, {}, { chains: 'solana' }))
       .rejects.toThrow(/timeframe-days/);
   });
+
+  it('rejects --page/--limit on historical-token-flow-summary', async () => {
+    mockApi = makeMockApi();
+    await expect(cmds.research(['historical-token-flow-summary'], mockApi, {}, {
+      'token-address': TOKENS.solana, 'from-date': FROM, 'to-date': TO, page: 2, limit: 5,
+    })).rejects.toThrow(/does not support/);
+  });
+
+  it('rejects --sort on historical-smart-money-balances', async () => {
+    mockApi = makeMockApi();
+    await expect(cmds.research(['historical-smart-money-balances'], mockApi, {}, {
+      'as-of-date': AS_OF, sort: 'value_usd:desc',
+    })).rejects.toThrow(/does not support/);
+  });
 });

src/commands/research.js

@@ -95,8 +95,8 @@ COMMON OPTIONS:
   --to-date <YYYY-MM-DD>     End of date range (for range-based subcommands)
   --as-of-date <YYYY-MM-DD>  Snapshot date (for as-of-date subcommands)
   --chain <chain>            Chain (default: solana for tokens, ethereum for wallets)
-  --page <n> --limit <n>     Pagination
-  --sort <field[:asc|desc]>  Sort order (default DESC)
+  --page <n> --limit <n>     Pagination (not supported by historical-token-flow-summary)
+  --sort <field[:asc|desc]>  Sort order (not supported by historical-smart-money-balances)
   --filters '<json>'         Filters as JSON object
 
 Run: nansen research <subcommand> --help`;
@@ -214,6 +214,12 @@ export function buildResearchCommands(deps = {}) {
           { 'token-address': options['token-address'] || options.token, 'from-date': fromDate, 'to-date': toDate },
           ['token-address', 'from-date', 'to-date'],
         );
+        if (sub === 'historical-token-flow-summary' && (options.page || options.limit)) {
+          throw new NansenError(
+            'historical-token-flow-summary does not support --page or --limit (endpoint returns a single aggregated row)',
+            ErrorCode.INVALID_PARAMS,
+          );
+        }
         return rangeTokenHandlers[sub]();
       }
 
@@ -240,6 +246,12 @@ export function buildResearchCommands(deps = {}) {
       }
 
       if (sub === 'historical-smart-money-balances') {
+        if (options.sort || options['order-by']) {
+          throw new NansenError(
+            'historical-smart-money-balances does not support --sort or --order-by (endpoint does not support ordering)',
+            ErrorCode.INVALID_PARAMS,
+          );
+        }
         requireOptions({ 'as-of-date': asOfDate }, ['as-of-date']);
         return apiInstance.researchSmartMoneyBalances({
           chains: parseChains(options),