changed php_unit_test_case_static_method_calls from static to this

Author: danielbannert

composer.json

@@ -25,10 +25,10 @@
         "pedrotroller/php-cs-custom-fixer": "^2.15.2"
     },
     "require-dev": {
-        "phpstan/phpstan": "^0.10.3",
-        "phpstan/phpstan-deprecation-rules": "^0.10.3",
-        "phpstan/phpstan-phpunit": "^0.10.3",
-        "phpstan/phpstan-strict-rules": "^0.10.3",
+        "phpstan/phpstan": "^0.10.5",
+        "phpstan/phpstan-deprecation-rules": "^0.10.5",
+        "phpstan/phpstan-phpunit": "^0.10.5",
+        "phpstan/phpstan-strict-rules": "^0.10.5",
         "phpunit/phpunit": "^7.2.0"
     },
     "config": {

src/Config.php

@@ -70,11 +70,8 @@ public function getRules(): array
                 'noise_remaining_usages' => false,
             ],
             'no_superfluous_phpdoc_tags'             => false,
-            'php_unit_test_case_static_method_calls' => [
-                'call_type' => 'static',
-            ],
-            'fopen_flags'      => false,
-            'fopen_flag_order' => false,
+            'fopen_flags'                            => false,
+            'fopen_flag_order'                       => false,
         ];
 
         $pedroTrollerRules = [

tests/ConfigTest.php

@@ -17,14 +17,14 @@ final class ConfigTest extends TestCase
 {
     public function testImplementsInterface(): void
     {
-        static::assertInstanceOf(ConfigInterface::class, new Config());
+        $this->assertInstanceOf(ConfigInterface::class, new Config());
     }
 
     public function testValues(): void
     {
         $config = new Config();
 
-        static::assertSame('narrowspark', $config->getName());
+        $this->assertSame('narrowspark', $config->getName());
     }
 
     public function testHasPsr2Rules(): void
@@ -67,20 +67,20 @@ public function testIfAllRulesAreTested(): void
         $rules = (new Config())->getRules();
 
         foreach ($rules as $key => $value) {
-            static::assertTrue(isset($testRules[$key]), '[' . $key . '] Rule is missing.');
+            $this->assertTrue(isset($testRules[$key]), '[' . $key . '] Rule is missing.');
         }
 
-        static::assertCount(\count($testRules), $rules);
+        $this->assertCount(\count($testRules), $rules);
     }
 
     public function testDoesNotHaveHeaderCommentFixerByDefault(): void
     {
         $rules = (new Config())->getRules();
 
-        static::assertArrayHasKey('header_comment', $rules);
-        static::assertFalse($rules['header_comment']);
-        static::assertTrue($rules['no_blank_lines_before_namespace']);
-        static::assertFalse($rules['single_blank_line_before_namespace']);
+        $this->assertArrayHasKey('header_comment', $rules);
+        $this->assertFalse($rules['header_comment']);
+        $this->assertTrue($rules['no_blank_lines_before_namespace']);
+        $this->assertFalse($rules['single_blank_line_before_namespace']);
     }
 
     public function testHasHeaderCommentFixerIfProvided(): void
@@ -89,17 +89,17 @@ public function testHasHeaderCommentFixerIfProvided(): void
         $config = new Config($header);
         $rules  = $config->getRules();
 
-        static::assertArrayHasKey('header_comment', $rules);
+        $this->assertArrayHasKey('header_comment', $rules);
 
         $expected = [
             'comment_type' => 'PHPDoc',
             'header'       => $header,
             'location'     => 'after_declare_strict',
             'separate'     => 'both',
         ];
-        static::assertSame($expected, $rules['header_comment']);
-        static::assertTrue($rules['no_blank_lines_before_namespace']);
-        static::assertFalse($rules['single_blank_line_before_namespace']);
+        $this->assertSame($expected, $rules['header_comment']);
+        $this->assertTrue($rules['no_blank_lines_before_namespace']);
+        $this->assertFalse($rules['single_blank_line_before_namespace']);
     }
 
     public function testAllConfiguredRulesAreBuiltIn(): void
@@ -119,7 +119,7 @@ public function testAllConfiguredRulesAreBuiltIn(): void
             \array_merge($this->builtInFixers(), $pedroTrollerRules)
         );
 
-        static::assertEmpty($fixersNotBuiltIn, \sprintf(
+        $this->assertEmpty($fixersNotBuiltIn, \sprintf(
             'Failed to assert that fixers for the rules "%s" are built in',
             \implode('", "', $fixersNotBuiltIn)
         ));
@@ -139,13 +139,13 @@ public function testDoesNotHaveRulesEnabled(string $fixer, $reason): void
         ];
 
         if ($fixer === 'array_syntax') {
-            static::assertNotSame(['syntax' => 'long'], $config->getRules()['array_syntax'], \sprintf(
+            $this->assertNotSame(['syntax' => 'long'], $config->getRules()['array_syntax'], \sprintf(
                 'Fixer "%s" should not be enabled, because "%s"',
                 $fixer,
                 $reason['long']
             ));
         } else {
-            static::assertArraySubset($rule, $config->getRules(), true, \sprintf(
+            $this->assertArraySubset($rule, $config->getRules(), true, \sprintf(
                 'Fixer "%s" should not be enabled, because "%s"',
                 $fixer,
                 $reason
@@ -353,7 +353,7 @@ private function getPHPUnitRules(): array
                 'use_class_const' => true,
             ],
             'php_unit_test_case_static_method_calls' => [
-                'call_type' => 'static',
+                'call_type' => 'this',
             ],
             'php_unit_internal_class' => [
                 'types' => [
@@ -548,12 +548,12 @@ private function getSymfonyRules(): array
     private function assertHasRules(array $expected, array $actual, string $set): void
     {
         foreach ($expected as $fixer => $isEnabled) {
-            static::assertArrayHasKey($fixer, $actual, \sprintf(
+            $this->assertArrayHasKey($fixer, $actual, \sprintf(
                 'Failed to assert that a rule for fixer "%s" (in set "%s") exists.,',
                 $fixer,
                 $set
             ));
-            static::assertSame($isEnabled, $actual[$fixer], \sprintf(
+            $this->assertSame($isEnabled, $actual[$fixer], \sprintf(
                 'Failed to assert that fixer "%s" (in set "%s") is %s.',
                 $fixer,
                 $set,