Develop (#10)

* Updated php-cs-fixer to stable v2 | added new tests | remove scrutinizer yml and changelog

* fix test

* remove old test

* dont use simplified_null_return | added test for long array

Author: prisis

src/Config.php

@@ -145,7 +145,7 @@ public function getRules(): array
             'semicolon_after_instruction'        => true,
             'short_scalar_cast'                  => true,
             'silenced_deprecation_error'         => false,
-            'simplified_null_return'             => true,
+            'simplified_null_return'             => false,
             'single_blank_line_before_namespace' => false,
             'single_quote'                       => true,
             'space_after_semicolon'              => true,

tests/ConfigTest.php

@@ -118,7 +118,13 @@ public function testDoesNotHaveRulesEnabled(string $fixer, $reason)
             $fixer => false,
         ];
 
-        if (! is_array($reason)) {
+        if ($fixer === 'array_syntax') {
+            $this->assertNotSame(['syntax' => 'long'], $config->getRules()['array_syntax'], sprintf(
+                'Fixer "%s" should not be enabled, because "%s"',
+                $fixer,
+                $reason['long']
+            ));
+        } else {
             $this->assertArraySubset($rule, $config->getRules(), true, sprintf(
                 'Fixer "%s" should not be enabled, because "%s"',
                 $fixer,
@@ -133,7 +139,7 @@ public function testDoesNotHaveRulesEnabled(string $fixer, $reason)
     public function providerDoesNotHaveFixerEnabled(): array
     {
         $symfonyFixers = [
-            'self_accessor'         => 'it causes an edge case error',
+            'self_accessor' => 'it causes an edge case error',
         ];
 
         $contribFixers = [
@@ -148,6 +154,7 @@ public function providerDoesNotHaveFixerEnabled(): array
             'psr0'                                      => 'we are using PSR-4',
             'strict_comparison'                         => 'it changes behaviour',
             'strict_param'                              => 'it changes behaviour',
+            'simplified_null_return'                    => 'it changes behaviour on void return'
         ];
 
         $fixers = array_merge($contribFixers, $symfonyFixers);
@@ -311,7 +318,7 @@ protected function getContribRules(): array
             'psr0'                                      => false,
             'psr4'                                      => true,
             'semicolon_after_instruction'               => true,
-            'simplified_null_return'                    => true,
+            'simplified_null_return'                    => false,
             'strict_comparison'                         => false,
             'strict_param'                              => false,
         ];