Skip to content
This repository was archived by the owner on Mar 1, 2023. It is now read-only.

Commit d44d454

Browse files
committed
Merge pull request #3 from narrowspark/develop
Fix: Update fabpot/php-cs-fixer
2 parents aaac9ec + 2bf36ee commit d44d454

File tree

5 files changed

+11
-42
lines changed

5 files changed

+11
-42
lines changed

README.md

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -21,33 +21,6 @@ Via Composer
2121
$ composer require narrowspark/php-cs-fixer-config
2222
```
2323

24-
:exclamation: Since `fabpot/php-cs-fixer:2.0.x-dev` isn't stable, we're pinning the dependency to a known commit.
25-
26-
There are two possibilities here
27-
28-
* you require that same commit in your repository
29-
30-
```
31-
$ composer require fabpot/php-cs-fixer-config:dev-master#8c4c643.
32-
```
33-
34-
* you configure `composer.json` in your root package with
35-
36-
```json
37-
{
38-
"minimum-stability": "dev",
39-
"prefer-stable": true
40-
}
41-
```
42-
and remove `fabpot/php-cs-fixer` with
43-
44-
```
45-
$ composer remove fabpot/php-cs-fixer
46-
```
47-
trusting us to pull in a working version.
48-
49-
For reference, see [`fabpot/php-cs-fixer-config:dev-master#8c4c643`](https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/8c4c643).
50-
5124
## Usage
5225

5326
Create a configuration file '.php_cs' in the root of your project:

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
],
2626
"require": {
2727
"php" : "^5.6 || ^7.0",
28-
"fabpot/php-cs-fixer" : "dev-master#8c4c643"
28+
"fabpot/php-cs-fixer" : "2.0.0-alpha"
2929
},
3030
"require-dev": {
3131
"phpunit/phpunit" : "^5.3"

composer.lock

Lines changed: 8 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Config.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ protected function getContribRules()
7878
'no_multiline_whitespaces_before_semicolon' => false,
7979
'no_php4_constructor' => false,
8080
'no_short_echo_tag' => true,
81+
'no_useless_else' => true,
8182
'no_useless_return' => true,
8283
'not_operators_with_space' => false,
8384
'not_operator_with_successor_space' => true,
@@ -139,8 +140,6 @@ private function getSymfonyRules()
139140
'no_alias_functions' => true,
140141
'no_blank_lines_after_class_opening' => true,
141142
'no_blank_lines_after_phpdoc' => true,
142-
'no_blank_lines_between_uses' => true,
143-
'no_duplicate_semicolons' => true,
144143
'no_empty_statement' => true,
145144
'no_extra_consecutive_blank_lines' => true,
146145
'no_leading_import_slash' => true,

tests/ConfigTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,6 @@ private function getSymfonyRules()
175175
'no_alias_functions' => true,
176176
'no_blank_lines_after_class_opening' => true,
177177
'no_blank_lines_after_phpdoc' => true,
178-
'no_blank_lines_between_uses' => true,
179-
'no_duplicate_semicolons' => true,
180178
'no_empty_statement' => true,
181179
'no_extra_consecutive_blank_lines' => true,
182180
'no_leading_import_slash' => true,
@@ -247,6 +245,7 @@ protected function getContribRules()
247245
'no_multiline_whitespaces_before_semicolon' => false,
248246
'no_php4_constructor' => false,
249247
'no_short_echo_tag' => true,
248+
'no_useless_else' => true,
250249
'no_useless_return' => true,
251250
'not_operators_with_space' => false,
252251
'not_operator_with_successor_space' => true,

0 commit comments

Comments
 (0)