Add MANC symmetric surface

[mmc46]

Is it possible to add a surface for the MANCsym template brain object?

[jefferis]

neuropil or tissue? We don't really have a good combined neuropil right now (just the one with many individual neuropil domains). For the time being you can do

MANCsym.surf.m=symmetric_manc(MANC.surf, mirror=T)

as per https://flyconnectome.github.io/malevnc/reference/mirror_manc.html#examples which I'm sure you've seen

[jefferis]

@dokato simplified the all-tissue mesh and that could be symmetrised.

[mmc46]

I meant just the tissue.

[jefferis]

@dokato would you mind adding a symmetric version of your tissue mesh as @mmc46 is asking?

[dokato]

Sure, see #15

[jefferis]

@mmc46 Were you think these all-tissue masks would be called MANC.surf and MANCsym.surf, respectively, so that one could do:

plot3d(MANC)
plot3d(MANCsym)

and get them?

[mmc46]

Yes, something like that.

…

On 13 Jun 2021, at 18:26, Gregory Jefferis ***@***.***> wrote:  @mmc46 Were you think these all-tissue masks would be called MANC.surf and MANCsym.surf, respectively, so that one could do: plot3d(MANC) plot3d(MANCsym) and get them? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[jefferis]

@dokato I think it would be good if you would update the names of the two surfaces to MANC.surf and MANCsym.surf and we will use them as the default for the dataset.

[dokato]

What happens then with:

#' @name MANC.surf
#' @aliases JRCFIBVNC2020MNP.surf

?
Should I override it with a tissue one?

IMHO the naming was good, as it indicated that this is a tissue surface.

[lisa-marin]

NB: this package now depends on R (>= 3.5.0) WARNING: Added dependency on R >= 3.5.0 because serialized objects in serialize/load version 3 cannot be read in older versions of R. File(s) containing such objects: 'malevnc/data/MANC.tissue.surf.sym.rda'

[dokato]

Indeed, I should have saved it with parameter to support backward compatibility, however, even quicker fix might be bumping up the minimum R version to 3.5, since even that is quite old as for now.

I'm about to fix naming anyway here, once @jefferis decides what to do with old MANC.surf object.