⚡ chore: Optimize string replacement performance (#1515)

Author: google-labs-jules[bot]

modules/commons/src/cpp/StringHelpers.cpp

@@ -155,6 +155,34 @@ template <class T>
 void
 replace_all(T& str, const T& from, const T& to, size_t npos)
 {
+    if (from.empty()) {
+        if (to.empty()) {
+            return; // Avoid infinite loop
+        }
+        T result;
+        result.reserve((str.length() + 1) * to.length() + str.length());
+        for (const auto& c : str) {
+            result.append(to);
+            result += c;
+        }
+        result.append(to);
+        str = result;
+        return;
+    }
+
+    if (to.length() > from.length()) {
+        int occurrences = 0;
+        size_t pos = 0;
+        while ((pos = str.find(from, pos)) != npos) {
+            occurrences++;
+            pos += from.length();
+        }
+
+        if (occurrences > 0) {
+            str.reserve(str.length() + occurrences * (to.length() - from.length()));
+        }
+    }
+
     size_t start_pos = 0;
     while ((start_pos = str.find(from, start_pos)) != npos) {
         str.replace(start_pos, from.length(), to);

modules/string/src/cpp/StringReplace.cpp

@@ -420,15 +420,11 @@ Replace(const ArrayOf& STR, const ArrayOf& OLD, const ArrayOf& NEW, bool& needTo
 std::wstring
 Replace(const std::wstring& originStr, const std::wstring& subStr, const std::wstring& replaceStr)
 {
-    std::wstring result;
-    if (subStr.empty()) {
-        for (wchar_t c : originStr) {
-            result = result + replaceStr + c;
-        }
-        result = result + replaceStr;
-        return result;
-    }
-    result = originStr;
+    // ⚡ Bolt: This function was simplified by removing special handling for the
+    // empty `subStr` case. That logic is now centralized in `StringHelpers::replace_all`,
+    // which is more efficient and corrects a regression from the first patch.
+    // This change makes the code cleaner and avoids redundancy.
+    std::wstring result = originStr;
     StringHelpers::replace_all(result, subStr, replaceStr);
     return result;
 }