fix: thread scopes up to Buildbot when recording deploy env vars

Author: ndhoule

packages/build/src/plugins/child/utils.ts

@@ -18,7 +18,7 @@ type BuildEvent = 'onPreBuild' | 'onBuild' | 'onPostBuild' | 'onError' | 'onSucc
 
 type RunState = Record<string, unknown>
 
-type DeployEnvVarsData = { key: string; value: string; isSecret: boolean }[]
+type DeployEnvVarsData = { key: string; value: string; isSecret: boolean; scopes: string[] }[]
 
 // Retrieve the `utils` argument.
 export const getUtils = function ({
@@ -72,9 +72,9 @@ const getDeployUtils = ({ deployEnvVars }: { deployEnvVars: DeployEnvVarsData })
 
       const existingDeployEnvVarIdx = deployEnvVars.findIndex((env) => env.key === key)
       if (existingDeployEnvVarIdx !== -1) {
-        deployEnvVars[existingDeployEnvVarIdx] = { key, value, isSecret }
+        deployEnvVars[existingDeployEnvVarIdx] = { key, value, isSecret, scopes: Array.from(normalizedScopes) }
       } else {
-        deployEnvVars.push({ key, value, isSecret })
+        deployEnvVars.push({ key, value, isSecret, scopes: Array.from(normalizedScopes) })
       }
 
       return env

packages/build/tests/deploy/tests.js

@@ -147,16 +147,19 @@ test('Deploy plugin specifies deploy-specific variables in deploy event', async
       isSecret: false,
       key: 'DATABASE_URI',
       value: '',
+      scopes: ['builds', 'functions', 'post_processing', 'runtime'],
     },
     {
       isSecret: true,
       key: 'DATABASE_PASSWORD',
       value: 'collision',
+      scopes: ['builds', 'functions', 'runtime'],
     },
     {
       isSecret: false,
       key: 'DATABASE_MOOD',
       value: 'feisty',
+      scopes: ['builds', 'functions', 'post_processing', 'runtime'],
     },
   ])
 })