Skip to content

Commit 43b0397

Browse files
committed
[actions] Exclude py 3.5, 3.6, 3.7 on macOS and Linux
They aren't compiled for macOS anymore.
1 parent fb0b81d commit 43b0397

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

.github/workflows/test.yml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,9 @@ jobs:
1919
strategy:
2020
matrix:
2121
# Start Linux jobs last since they are fastest to start and complete, and start 3.12 first,
22-
# since it pairs wiht macOS+Windows jobs, and 3.5 and 3.6 last since they only run tests and
23-
# don't use venv. 3.4 is not supported on GitHub anymore and 3.5 and 3.6 for x64 isn't
24-
# produced for ubuntu 22.04.
25-
python-version: ['3.12', '3.11', '3.10', 3.9, 3.8, 3.7, 3.6, 3.5]
22+
# since it pairs wiht macOS+Windows jobs. 3.4 is not supported on GitHub anymore and 3.5,
23+
# 3.6, and 3.7 for x64 isn't produced for Ubuntu 22.04 and macOS.
24+
python-version: ['3.12', '3.11', '3.10', 3.9, 3.8]
2625
os: [windows-latest, macos-latest, ubuntu-latest]
2726

2827
# Choose test script depending on OS.
@@ -36,11 +35,10 @@ jobs:
3635

3736
exclude:
3837
# Only test on macOS and Windows with Python 3.12.
39-
# But do test 3.5 and 3.6 on macOS because they aren't compiled for x64 on Ubuntu 22.04.
40-
# - os: macos-latest
41-
# python-version: 3.5
42-
# - os: macos-latest
43-
# python-version: 3.6
38+
- os: macos-latest
39+
python-version: 3.5
40+
- os: macos-latest
41+
python-version: 3.6
4442
- os: macos-latest
4543
python-version: 3.7
4644
- os: macos-latest
@@ -67,12 +65,13 @@ jobs:
6765
- os: windows-latest
6866
python-version: '3.11'
6967

70-
# Ignore 3.5 and 3.6 on Linux because it isn't compiled for x64 on Ubuntu 22.04.
71-
# Test on macOS instead.
68+
# Ignore 3.5, 3.6, and 3.7 on Linux because it isn't compiled for x64 on Ubuntu 22.04.
7269
- os: ubuntu-latest
7370
python-version: 3.5
7471
- os: ubuntu-latest
7572
python-version: 3.6
73+
- os: ubuntu-latest
74+
python-version: 3.7
7675

7776
steps:
7877
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

0 commit comments

Comments
 (0)