DateTime: strict behavior (BC break)

Author: dg

src/Utils/DateTime.php

@@ -120,7 +120,7 @@ public function modify(string $modifier): static
 	public function setDate(int $year, int $month, int $day): static
 	{
 		if (!checkdate($month, $day, $year)) {
-			trigger_error(sprintf(self::class . ': The date %04d-%02d-%02d is not valid.', $year, $month, $day), E_USER_WARNING);
+			throw new \Exception(sprintf('The date %04d-%02d-%02d is not valid.', $year, $month, $day));
 		}
 		return parent::setDate($year, $month, $day);
 	}
@@ -134,7 +134,7 @@ public function setTime(int $hour, int $minute, int $second = 0, int $microsecon
 			|| $second < 0 || $second >= 60
 			|| $microsecond < 0 || $microsecond >= 1_000_000
 		) {
-			trigger_error(sprintf(self::class . ': The time %02d:%02d:%08.5F is not valid.', $hour, $minute, $second + $microsecond / 1_000_000), E_USER_WARNING);
+			throw new \Exception(sprintf('The time %02d:%02d:%08.5F is not valid.', $hour, $minute, $second + $microsecond / 1_000_000));
 		}
 		return parent::setTime($hour, $minute, $second, $microsecond);
 	}
@@ -211,7 +211,7 @@ private function handleErrors(string $value): void
 		$errors = self::getLastErrors();
 		$errors = array_merge($errors['errors'] ?? [], $errors['warnings'] ?? []);
 		if ($errors) {
-			trigger_error(self::class . ': ' . implode(', ', $errors) . " '$value'", E_USER_WARNING);
+			throw new \Exception(implode(', ', $errors) . " '$value'");
 		}
 	}
 }

tests/Utils/DateTime.construct.phpt

@@ -101,21 +101,21 @@ test('Exception handling for invalid input', function () {
 		'%a%invalid date format%a%',
 	);
 
-	Assert::error(
+	Assert::exception(
 		fn() => new DateTime('0000-00-00'),
-		E_USER_WARNING,
-		"Nette\\Utils\\DateTime: The parsed date was invalid '0000-00-00'",
+		Throwable::class,
+		"The parsed date was invalid '0000-00-00'",
 	);
 
-	Assert::error(
+	Assert::exception(
 		fn() => new DateTime('2024-02-31 10:00:00'), // Invalid day for February
-		E_USER_WARNING,
-		"Nette\\Utils\\DateTime: The parsed date was invalid '2024-02-31 10:00:00'",
+		Throwable::class,
+		"The parsed date was invalid '2024-02-31 10:00:00'",
 	);
 
-	Assert::error(
+	Assert::exception(
 		fn() => new DateTime('1978-01-23 23:00:60'),
-		E_USER_WARNING,
-		"Nette\\Utils\\DateTime: The parsed time was invalid '1978-01-23 23:00:60'",
+		Throwable::class,
+		"The parsed time was invalid '1978-01-23 23:00:60'",
 	);
 });

tests/Utils/DateTime.modify.phpt

@@ -167,22 +167,22 @@ test('Complex and varied format strings', function () {
 
 test('Invalid modifier format exceptions', function () {
 	if (PHP_VERSION_ID < 80300) {
-		Assert::error(
+		Assert::exception(
 			fn() => (new DateTime)->modify('+'),
-			E_WARNING,
+			Throwable::class,
 			'DateTime::modify(): Failed to parse time string (+) at position 0 (+): Unexpected character',
 		);
 	} else {
-		Assert::error(
+		Assert::exception(
 			fn() => (new DateTime)->modify('+'),
 			DateMalformedStringException::class,
 			'DateTime::modify(): Failed to parse time string (+) at position 0 (+): Unexpected character',
 		);
 	}
 
-	Assert::error(
+	Assert::exception(
 		fn() => (new DateTime)->modify('2024-02-31 10:00:00'), // Invalid day for February
-		E_USER_WARNING,
-		"Nette\\Utils\\DateTime: The parsed date was invalid '2024-02-31 10:00:00'",
+		Throwable::class,
+		"The parsed date was invalid '2024-02-31 10:00:00'",
 	);
 });

tests/Utils/DateTime.relativeToSeconds.phpt

@@ -29,8 +29,8 @@ test('relativeToSeconds throws on invalid', function () {
 		'%a?%Failed to parse time string %a%',
 	);
 
-	Assert::error(
+	Assert::exception(
 		fn() => DateTime::relativeToSeconds('1 minu'),
-		E_USER_WARNING,
+		Throwable::class,
 	);
 });

tests/Utils/DateTime.setDateTime.phpt

@@ -12,14 +12,14 @@ use Tester\Assert;
 require __DIR__ . '/../bootstrap.php';
 
 
-Assert::error(
+Assert::exception(
 	fn() => (new DateTime)->setDate(1978, 2, 31),
-	E_USER_WARNING,
-	'Nette\Utils\DateTime: The date 1978-02-31 is not valid.',
+	Throwable::class,
+	'The date 1978-02-31 is not valid.',
 );
 
-Assert::error(
+Assert::exception(
 	fn() => (new DateTime)->setTime(0, 60),
-	E_USER_WARNING,
-	'Nette\Utils\DateTime: The time 00:60:00.00000 is not valid.',
+	Throwable::class,
+	'The time 00:60:00.00000 is not valid.',
 );