Skip to content

[Enabler] Filtering events - refactor code #35

@glass-ships

Description

@glass-ships

'- doc update on EventList:FilterInPlace: GitHub issue/pull request detail

  • copy_if: GitHub issue/pull request detail

Description:

This will prepare mantid for the new way of filtering logs as detailed in the design document.

The work focuses on modifying private methods in DataObjects::EventList to use Kernel::TimeROI, plus a few small changes.

This enabler will cover step 6 of the "implementation notes" section of the design document.

Outline of activity:

* [ ] Add erase_if method to DataObjects::EventList

  • Add copy_if method to DataObjects::EventList
  • Replace the private methods
    • filterByPulseTimeHelper: should be replaced with the copy_if
    • filterByTimeAtSampleHelper: should be replaced with the copy_if
    • filterInPlaceHelper: should be refactored following maskTOF example
  • [ ] Changes to Instrument
  • [ ] Changes to Goniometer

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions