Merge pull request #399 from Amitdwivedi22/fix/prevent-duplicate-approval

Fix: Prevent re-requesting approval for already approved files

Author: lukasdotcom

lib/Service/ApprovalService.php

@@ -461,6 +461,9 @@ public function request(int $fileId, int $ruleId, ?string $userId, bool $createS
 		}
 
 		if ($this->userIsAuthorizedByRule($userId, $rule, 'requesters')) {
+			if ($this->tagObjectMapper->haveTag((string)$fileId, 'files', $rule['tagApproved'])) {
+				return ['error' => $this->l10n->t('Approval has already been granted with this rule for this file')];
+			}
 			// only request if it has not yet been requested for this rule
 			if (!$this->tagObjectMapper->haveTag((string)$fileId, 'files', $rule['tagPending'])) {
 				if ($createShares) {