Remove createdShares and mention warning in readme for groups as approvers

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>

Author: lukasdotcom

README.md

@@ -34,6 +34,8 @@ Workflows can be chained. For example, if the approved tag of a workflow A is us
 then once a file is approved by the workflow A, it becomes pending for the B one. For an example of a chain involving a leave
 request that needs to be approved by a manager and then the department head, there is a screenshot below.
 
+**Notice**: If the approvers are a group the file may be shared with the individual users of the group instead of the group.
+
 ![Workflow chain](https://github.com/nextcloud/approval/raw/main/img/screenshot_chained.jpg)
 
 ## Tag assignment

lib/Service/ApprovalService.php

@@ -529,17 +529,16 @@ public function requestViaTagAssignment(int $fileId, int $ruleId, string $reques
 	 * @param int $fileId
 	 * @param Rule $rule
 	 * @param string $userId
-	 * @return array list of created shares
+	 * @return void
 	 * @throws \OCP\Files\NotPermittedException
 	 * @throws \OC\User\NoUserException
 	 */
-	private function shareWithApprovers(int $fileId, array $rule, string $userId): array {
-		$createdShares = [];
+	private function shareWithApprovers(int $fileId, array $rule, string $userId): void {
 		// get node
 		$userFolder = $this->root->getUserFolder($userId);
 		$node = $userFolder->getFirstNodeById($fileId);
 		if ($node === null) {
-			return [];
+			return;
 		}
 		// get the node again from the owner's storage to avoid sharing permission issues
 		$ownerId = $node->getOwner()->getUID();
@@ -558,8 +557,8 @@ private function shareWithApprovers(int $fileId, array $rule, string $userId): a
 		foreach ($rule['approvers'] as $approver) {
 			if ($approver['type'] === 'user' && !in_array($approver['entityId'], $userIdsWithAccess, true)) {
 				// create user share
-				if ($this->utilsService->createShare($node, IShare::TYPE_USER, $approver['entityId'], $fileOwner, $label)) {
-					$createdShares[] = $approver;
+				if (!$this->utilsService->createShare($node, IShare::TYPE_USER, $approver['entityId'], $fileOwner, $label)) {
+					$this->logger->warning('Failed to create user share for file {fileId} with approver {approverId}', ['fileId' => $fileId, 'approverId' => $approver['entityId']]);
 				}
 			}
 		}
@@ -571,20 +570,16 @@ private function shareWithApprovers(int $fileId, array $rule, string $userId): a
 					$groupMembersThatNeedAccess = array_diff($groupMemberIds, $userIdsWithAccess);
 					// Create group share if everyone in the group needs access
 					if (count($groupMembersThatNeedAccess) === count($groupMemberIds)) {
-						if ($this->utilsService->createShare($node, IShare::TYPE_GROUP, $approver['entityId'], $fileOwner, $label)) {
-							$createdShares[] = $approver;
+						if (!$this->utilsService->createShare($node, IShare::TYPE_GROUP, $approver['entityId'], $fileOwner, $label)) {
+							$this->logger->warning('Failed to create group share for file {fileId} with approver {approverId}', ['fileId' => $fileId, 'approverId' => $approver['entityId']]);
 						}
 					} elseif (count($groupMembersThatNeedAccess) > 0) {
 						// Create user shares for each member that needs access
-						$success = true;
 						foreach ($groupMembersThatNeedAccess as $groupMemberId) {
 							if (!$this->utilsService->createShare($node, IShare::TYPE_USER, $groupMemberId, $fileOwner, $label)) {
-								$success = false;
+								$this->logger->warning('Failed to create user share for file {fileId} with approver {approverId}', ['fileId' => $fileId, 'approverId' => $groupMemberId]);
 							}
 						}
-						if ($success) {
-							$createdShares[] = $approver;
-						}
 					}
 				}
 			}
@@ -594,14 +589,12 @@ private function shareWithApprovers(int $fileId, array $rule, string $userId): a
 		if ($circlesEnabled) {
 			foreach ($rule['approvers'] as $approver) {
 				if ($approver['type'] === 'circle') {
-					if ($this->utilsService->createShare($node, IShare::TYPE_CIRCLE, $approver['entityId'], $fileOwner, $label)) {
-						$createdShares[] = $approver;
+					if (!$this->utilsService->createShare($node, IShare::TYPE_CIRCLE, $approver['entityId'], $fileOwner, $label)) {
+						$this->logger->warning('Failed to create circle share for file {fileId} with approver {approverId}', ['fileId' => $fileId, 'approverId' => $approver['entityId']]);
 					}
 				}
 			}
 		}
-
-		return $createdShares;
 	}
 
 	/**