feat(lexicon): get value type from lexicon

Signed-off-by: Maxence Lange <[email protected]>

Author: ArtificialOwl

apps/provisioning_api/lib/Controller/AppConfigController.php

@@ -16,6 +16,7 @@
 use OCP\AppFramework\Http\Attribute\PasswordConfirmationRequired;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCSController;
+use OCP\Config\ValueType;
 use OCP\Exceptions\AppConfigUnknownKeyException;
 use OCP\IAppConfig;
 use OCP\IGroupManager;
@@ -130,19 +131,27 @@ public function setValue(string $app, string $key, string $value): DataResponse
 		}
 
 		$type = null;
-		try {
-			$configDetails = $this->appConfig->getDetails($app, $key);
-			$type = $configDetails['type'];
-		} catch (AppConfigUnknownKeyException) {
+
+		// checking expected type from lexicon
+		$keyDetails = $this->appConfig->getKeyDetails($app, $key);
+		if (array_key_exists('valueType', $keyDetails)) {
+			$type = $keyDetails['valueType'];
+		} else {
+			// if no details from lexicon, get from eventual current value in database
+			try {
+				$configDetails = $this->appConfig->getDetails($app, $key);
+				$type = $configDetails['type'];
+			} catch (AppConfigUnknownKeyException) {
+			}
 		}
 
 		/** @psalm-suppress InternalMethod */
 		match ($type) {
-			IAppConfig::VALUE_BOOL => $this->appConfig->setValueBool($app, $key, (bool)$value),
-			IAppConfig::VALUE_FLOAT => $this->appConfig->setValueFloat($app, $key, (float)$value),
-			IAppConfig::VALUE_INT => $this->appConfig->setValueInt($app, $key, (int)$value),
-			IAppConfig::VALUE_STRING => $this->appConfig->setValueString($app, $key, $value),
-			IAppConfig::VALUE_ARRAY => $this->appConfig->setValueArray($app, $key, \json_decode($value, true)),
+			IAppConfig::VALUE_BOOL, ValueType::BOOL => $this->appConfig->setValueBool($app, $key, (bool)$value),
+			IAppConfig::VALUE_FLOAT, ValueType::FLOAT => $this->appConfig->setValueFloat($app, $key, (float)$value),
+			IAppConfig::VALUE_INT, ValueType::INT => $this->appConfig->setValueInt($app, $key, (int)$value),
+			IAppConfig::VALUE_STRING, ValueType::STRING => $this->appConfig->setValueString($app, $key, $value),
+			IAppConfig::VALUE_ARRAY, ValueType::ARRAY => $this->appConfig->setValueArray($app, $key, \json_decode($value, true)),
 			default => $this->appConfig->setValueMixed($app, $key, $value),
 		};