feat(updater): add a config toggle to disable adding the BackgroundCleanupUpdaterBackupsJob

Since the updater can be used with --no-backup, which doesn't create the backups folder in the first
place, it isn't required to make this check, which sends a warning-level log if it doesn't find the
folder.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Author: tcitworld

config/config.sample.php

@@ -982,6 +982,14 @@
 	 */
 	'updater.release.channel' => 'stable',
 
+	/**
+	 * Does Nextcloud needs to cleanup old backups after an update has been
+	 * performed?
+	 *
+	 * Defaults to ``true``
+	 */
+	'updater.cleanup_backups' => true,
+
 	/**
 	 * Is Nextcloud connected to the Internet or running in a closed network?
 	 *

lib/private/Repair/AddCleanupUpdaterBackupsJob.php

@@ -10,12 +10,14 @@
 
 use OC\Core\BackgroundJobs\BackgroundCleanupUpdaterBackupsJob;
 use OCP\BackgroundJob\IJobList;
+use OCP\IConfig;
 use OCP\Migration\IOutput;
 use OCP\Migration\IRepairStep;
 
 class AddCleanupUpdaterBackupsJob implements IRepairStep {
 	public function __construct(
 		protected readonly IJobList $jobList,
+		protected readonly IConfig $config,
 	) {
 	}
 
@@ -24,6 +26,8 @@ public function getName(): string {
 	}
 
 	public function run(IOutput $output): void {
-		$this->jobList->add(BackgroundCleanupUpdaterBackupsJob::class);
+		if ($this->config->getSystemValueBool('updater.cleanup_backups', true)) {
+			$this->jobList->add(BackgroundCleanupUpdaterBackupsJob::class);
+		}
 	}
 }