Skip to content

Commit 3ceae3a

Browse files
authored
Remove Wave Dockerfile Singularity builds (#7042)
* chore: Move scripts to scripts * fix: Add rich_click as a dependency Not all of us have it installed to our system Python environment @ewels ;) * ci: Remove Dockerfile and wave builds Per Paolo, you need a singularity file to build a Singularity image not a Dockerfile
1 parent a0e49eb commit 3ceae3a

File tree

6 files changed

+2
-5
lines changed

6 files changed

+2
-5
lines changed
File renamed without changes.
File renamed without changes.
File renamed without changes.

.github/scripts/wave_singularity.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# dependencies = [
55
# "requests",
66
# "rich",
7+
# "rich_click"
78
# ]
89
# ///
910

.github/workflows/wave.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,14 @@ jobs:
8888
# if: github.repository == 'nf-core/modules'
8989
if: ${{ needs.generate-matrix.outputs.docker-matrix != '[]' }}
9090
needs: generate-matrix
91-
name: Build Dockerfile-based ${{ matrix.profile }} Container
91+
name: Build Dockerfile-based Container
9292
runs-on: ubuntu-latest
9393
timeout-minutes: 60
9494
strategy:
9595
fail-fast: false
9696
max-parallel: 4
9797
matrix:
9898
files: "${{ fromJson(needs.generate-matrix.outputs.docker-matrix) }}"
99-
profile: [docker, singularity]
10099
steps:
101100
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
102101

@@ -117,11 +116,8 @@ jobs:
117116
- name: Build ${{ matrix.profile }} container
118117
# NOTE If you're changing a Dockerfile and this is running, try to update the Dockerfile to build with wave
119118
continue-on-error: false
120-
env:
121-
PROFILE: ${{ (contains(matrix.profile, 'singularity') && '--singularity') || '' }}
122119
run: |
123120
wave -f "${{ matrix.files }}" \
124-
$PROFILE \
125121
--freeze \
126122
--await \
127123
--build-repo quay.io/nf-core/modules/${{steps.registry-name.outputs.result}} \

0 commit comments

Comments
 (0)