Skip to content

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Mar 29, 2025

Proposed changes

#7583

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hafe hafe requested a review from a team as a code owner March 29, 2025 09:31
Copy link
Contributor

github-actions bot commented Mar 29, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the go Pull requests that update Go code label Mar 29, 2025
@hafe
Copy link
Contributor Author

hafe commented Mar 29, 2025

I have hereby read the F5 CLA and agree to its terms

@hafe hafe force-pushed the 7583-fix-service-insight branch from 866fa6e to 9cf2d18 Compare May 21, 2025 17:23
@hafe
Copy link
Contributor Author

hafe commented Jun 2, 2025

Any comments?

@hafe
Copy link
Contributor Author

hafe commented Jun 27, 2025

Ping

@pdabelf5
Copy link
Collaborator

@hafe we're looking to get this merged for you. Can you remove the unused function virtualServerForHost()? It is blocking the tests in the CI pipeline from passing.

@pdabelf5 pdabelf5 linked an issue Jul 17, 2025 that may be closed by this pull request
@hafe hafe force-pushed the 7583-fix-service-insight branch from 1e35bee to 744e46f Compare July 20, 2025 07:02
@pdabelf5 pdabelf5 merged commit 3f05f59 into nginx:main Jul 21, 2025
135 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Insight does not work for cross-namespace-configuration
4 participants