Review fixes

* delete commented out code
* delete CRD test as it was not useful

Author: mrajagopal

pkg/crds/crd_test.go

@@ -14,12 +14,6 @@ import (
 )
 
 func TestNGXJobList_ExecNginxT(t *testing.T) {
-	// dc := &data_collector.DataCollector{
-	// 	BaseDir:    tmpDir,
-	// 	Logger:     log.New(io.Discard, "", 0),
-	// 	Namespaces: []string{"default"},
-	// }
-
 	dc := mock.SetupMockDataCollector(t)
 
 	// Create a fake pod named "nginx-123" in the "default" namespace

pkg/jobs/ngx_job_list_test.go

@@ -15,11 +15,6 @@ import (
 )
 
 func TestNIMJobList_ExecJobs(t *testing.T) {
-	// dc := &data_collector.DataCollector{
-	// 	BaseDir:    tmpDir,
-	// 	Logger:     log.New(io.Discard, "", 0),
-	// 	Namespaces: []string{"default"},
-	// }
 	dc := mock.SetupMockDataCollector(t)
 	dc.Namespaces = []string{"default"}
 

pkg/jobs/nim_job_list_test.go

@@ -103,7 +103,11 @@ func SetupMockDataCollector(t *testing.T) *data_collector.DataCollector {
 		t.Fail()
 	}
 	helmClient.EXPECT().GetSettings().Return(&cli.EnvSettings{}).AnyTimes()
-	var mockedRelease = release.Release{Name: "test", Namespace: "test", Manifest: "apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: example-config\n  namespace: default\ndata:\n  key: value\n"}
+	var mockedRelease = release.Release{
+		Name:      "test",
+		Namespace: "test",
+		Manifest:  "apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: example-config\n  namespace: default\ndata:\n  key: value\n",
+	}
 	helmClient.EXPECT().ListDeployedReleases().Return([]*release.Release{&mockedRelease}, nil).AnyTimes()
 
 	return &data_collector.DataCollector{