fix: adjust AWS logic to force delete ECR registry that contains images (#211)

* fix: adjusted ECR to force delete unused registry

* fix: remove unneeded registry delete

Author: Jason Schmidt

extras/jenkins/AWS/Jenkinsfile

@@ -188,15 +188,11 @@ pipeline {
          * Clean up the environment; this includes running the destroy script to remove our pulumi resources and
          * destroy the deployed infrastructure in AWS
          *
-         * AWS will not remove a registry that contains images, so we do a force removal here; this should ultimately
-         * be fixed in the code.
-         *
          * After that completes, we remove the pulumi stack from the project with the find command; this is because
          * we need to delete the stack in each project it's been instantiated in.
          */
 
           sh '''
-            $WORKSPACE/pulumi/python/venv/bin/aws ecr delete-repository --repository-name ingress-controller-marajenkaws${BUILD_NUMBER} --force
             $WORKSPACE/pulumi/python/runner -p aws -s marajenkaws${BUILD_NUMBER} destroy
             find . -mindepth 2 -maxdepth 6 -type f -name Pulumi.yaml -execdir $WORKSPACE/pulumi/python/venv/bin/pulumi stack rm marajenkaws${BUILD_NUMBER} --force --yes \\;
              '''

pulumi/python/infrastructure/aws/ecr/__main__.py

@@ -8,7 +8,7 @@
 ecr_repo = ecr.Repository(name=f'ingress-controller-{stack_name}',
                           resource_name=f'nginx-ingress-repository-{stack_name}',
                           image_tag_mutability="MUTABLE",
-                          force_delete=False,
+                          force_delete=True,
                           tags={"Project": project_name, "Stack": stack_name})
 
 pulumi.export('repository_url', ecr_repo.repository_url)