Skip to content

Commit 50e5320

Browse files
STY: Apply ruff/refurb rule FURB113
FURB113 Use `list.extend(...)` instead of repeatedly calling `list.append()`
1 parent d52a62d commit 50e5320

File tree

3 files changed

+22
-32
lines changed

3 files changed

+22
-32
lines changed

nipype/interfaces/ants/registration.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,14 +1127,10 @@ def _format_metric_argument(**kwargs):
11271127
return retval
11281128

11291129
def _format_transform(self, index):
1130-
retval = []
1131-
retval.append("%s[ " % self.inputs.transforms[index])
11321130
parameters = ", ".join(
11331131
[str(element) for element in self.inputs.transform_parameters[index]]
11341132
)
1135-
retval.append("%s" % parameters)
1136-
retval.append(" ]")
1137-
return "".join(retval)
1133+
return f"{self.inputs.transforms[index]}[ {parameters} ]"
11381134

11391135
def _format_registration(self):
11401136
retval = []

nipype/pipeline/engine/workflows.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -483,12 +483,8 @@ def write_graph(
483483
def write_hierarchical_dotfile(
484484
self, dotfilename=None, colored=False, simple_form=True
485485
):
486-
dotlist = ["digraph %s{" % self.name]
487-
dotlist.append(
488-
self._get_dot(prefix=" ", colored=colored, simple_form=simple_form)
489-
)
490-
dotlist.append("}")
491-
dotstr = "\n".join(dotlist)
486+
dotlist = self._get_dot(prefix=" ", colored=colored, simple_form=simple_form)
487+
dotstr = f"digraph {self.name}{{\n{dotlist}\n}}"
492488
if dotfilename:
493489
fp = open(dotfilename, "w")
494490
fp.writelines(dotstr)
@@ -1068,23 +1064,27 @@ def _get_dot(
10681064
nodename = fullname.replace(".", "_")
10691065
dotlist.append("subgraph cluster_%s {" % nodename)
10701066
if colored:
1071-
dotlist.append(
1072-
prefix + prefix + 'edge [color="%s"];' % (colorset[level + 1])
1073-
)
1074-
dotlist.append(prefix + prefix + "style=filled;")
1075-
dotlist.append(
1076-
prefix + prefix + 'fillcolor="%s";' % (colorset[level + 2])
1067+
dotlist.extend(
1068+
(
1069+
prefix
1070+
+ prefix
1071+
+ 'edge [color="%s"];' % (colorset[level + 1]),
1072+
prefix + prefix + "style=filled;",
1073+
prefix + prefix + 'fillcolor="%s";' % (colorset[level + 2]),
1074+
)
10771075
)
1078-
dotlist.append(
1079-
node._get_dot(
1080-
prefix=prefix + prefix,
1081-
hierarchy=hierarchy + [self.name],
1082-
colored=colored,
1083-
simple_form=simple_form,
1084-
level=level + 3,
1076+
dotlist.extend(
1077+
(
1078+
node._get_dot(
1079+
prefix=prefix + prefix,
1080+
hierarchy=hierarchy + [self.name],
1081+
colored=colored,
1082+
simple_form=simple_form,
1083+
level=level + 3,
1084+
),
1085+
"}",
10851086
)
10861087
)
1087-
dotlist.append("}")
10881088
else:
10891089
for subnode in self._graph.successors(node):
10901090
if node._hierarchy != subnode._hierarchy:

nipype/utils/docparse.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -166,13 +166,7 @@ def insert_doc(doc, new_items):
166166
# Add rest of documents
167167
tmpdoc.extend(doclist[2:])
168168
# Insert newlines
169-
newdoc = []
170-
for line in tmpdoc:
171-
newdoc.append(line)
172-
newdoc.append("\n")
173-
# We add one too many newlines, remove it.
174-
newdoc.pop(-1)
175-
return "".join(newdoc)
169+
return "\n".join(tmpdoc)
176170

177171

178172
def build_doc(doc, opts):

0 commit comments

Comments
 (0)