chore(lint): format for the new golangci-lint version (#283)

Author: nobe4

internal/cmd/config.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"context"
 	"errors"
 	"fmt"
 	"log/slog"
@@ -84,7 +85,7 @@ func editConfig() error {
 		return errNoEditor
 	}
 
-	cmd := exec.Command(editor, config.Path)
+	cmd := exec.CommandContext(context.TODO(), editor, config.Path)
 
 	cmd.Stdin = os.Stdin
 	cmd.Stdout = os.Stdout

internal/gh/gh.go

@@ -65,6 +65,7 @@ func isRetryable(e error) bool {
 		switch httpError.StatusCode {
 		case http.StatusNotFound, http.StatusBadGateway, http.StatusGatewayTimeout: // expected status code
 			return true
+		default:
 		}
 	}
 

internal/gh/gh_test.go

@@ -273,7 +273,7 @@ func TestParse(t *testing.T) {
 			notifications, next, err := parse(test.response)
 
 			if test.fails && err == nil {
-				t.Errorf("expected test to fails")
+				t.Error("expected test to fails")
 			} else if !test.fails && err != nil {
 				t.Errorf("expected test to pass, got %#v", err)
 			}
@@ -338,7 +338,7 @@ func TestRequest(t *testing.T) {
 
 		_, _, err := client.request(verb, endpoint, nil)
 		if err == nil {
-			t.Errorf("expected test to fails")
+			t.Error("expected test to fails")
 		}
 
 		if !errors.Is(err, errExpected) {
@@ -361,7 +361,7 @@ func TestRequest(t *testing.T) {
 
 		notifications, next, err := client.request(verb, endpoint, nil)
 		if err != nil {
-			t.Errorf("expected test to pass")
+			t.Error("expected test to pass")
 		}
 
 		if next != "https://next.page" {
@@ -634,7 +634,7 @@ func TestEnrich(t *testing.T) {
 			assertError: func(t *testing.T, err error) {
 				t.Helper()
 				if err == nil {
-					t.Fatalf("expected error but got nil")
+					t.Fatal("expected error but got nil")
 				}
 
 				expected := &json.SyntaxError{}

internal/jq/jq_test.go

@@ -49,7 +49,7 @@ func TestFilter(t *testing.T) {
 			assertErr: func(t *testing.T, err error) {
 				t.Helper()
 				if err == nil {
-					t.Fatalf("expected error but got nil")
+					t.Fatal("expected error but got nil")
 				}
 
 				expected := &gojq.ParseError{}
@@ -134,7 +134,7 @@ func TestValidate(t *testing.T) {
 			assertErr: func(t *testing.T, err error) {
 				t.Helper()
 				if err == nil {
-					t.Fatalf("expected error but got nil")
+					t.Fatal("expected error but got nil")
 				}
 
 				expected := &gojq.ParseError{}

internal/logger/logger.go

@@ -38,6 +38,8 @@ func initWithWriter(w io.Writer, verbosity int) {
 	case 5:
 		opts.Level = slog.LevelDebug
 		opts.AddSource = true
+	default:
+		opts.Level = slog.LevelInfo
 	}
 
 	handler := slog.NewTextHandler(w, opts)

internal/manager/manager.go

@@ -141,7 +141,7 @@ func (m *Manager) refreshNotifications() error {
 	}
 
 	//nolint:forbidigo // This is an expected print statement.
-	fmt.Printf("Refreshing notifications...\n")
+	fmt.Print("Refreshing notifications...\n")
 
 	remoteNotifications, err := m.client.Notifications()
 	if err != nil {

internal/manager/strategies.go

@@ -32,9 +32,9 @@ func (r *RefreshStrategy) String() string {
 		return "force"
 	case PreventRefresh:
 		return "prevent"
+	default:
+		return "unknown"
 	}
-
-	return "unknown"
 }
 
 func (*RefreshStrategy) Allowed() string {
@@ -125,9 +125,7 @@ func (*ForceStrategy) Allowed() string {
 }
 
 func (r *ForceStrategy) Set(value string) error {
-	v := strings.Split(value, ",")
-
-	for _, s := range v {
+	for s := range strings.SplitSeq(value, ",") {
 		switch s {
 		case "apply":
 			*r |= ForceApply

internal/manager/strategies_test.go

@@ -44,11 +44,12 @@ func TestRefreshStrategy(t *testing.T) {
 				t.Parallel()
 
 				var got RefreshStrategy
+
 				err := got.Set(test.value)
 
 				if test.error {
 					if err == nil {
-						t.Errorf("expected an error but got none")
+						t.Error("expected an error but got none")
 					}
 				} else {
 					if err != nil {
@@ -106,11 +107,12 @@ func TestForceStrategy(t *testing.T) {
 				t.Parallel()
 
 				var got ForceStrategy
+
 				err := got.Set(test.value)
 
 				if test.error {
 					if err == nil {
-						t.Errorf("expected an error but got none")
+						t.Error("expected an error but got none")
 					}
 				} else {
 					if err != nil {

internal/notifications/sync_test.go

@@ -112,15 +112,15 @@ func TestSync(t *testing.T) {
 		)
 
 		if !got[0].Meta.RemoteExists {
-			t.Fatalf("expected RemoteExists to be true but got false")
+			t.Fatal("expected RemoteExists to be true but got false")
 		}
 
 		if got[1].Meta.RemoteExists {
-			t.Fatalf("expected RemoteExists to be false but got true")
+			t.Fatal("expected RemoteExists to be false but got true")
 		}
 
 		if !got[2].Meta.RemoteExists {
-			t.Fatalf("expected RemoteExists to be true but got false")
+			t.Fatal("expected RemoteExists to be true but got false")
 		}
 	})
 

internal/repl/handlers.go

@@ -59,9 +59,12 @@ func (m model) handleCommand(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 
 	case key.Matches(msg, m.keymap.CommandCancel):
 		return m.cancelCommand()
+
+	default:
 	}
 
 	var cmd tea.Cmd
+
 	m.command, cmd = m.command.Update(msg)
 
 	return m, cmd
@@ -77,16 +80,20 @@ func (m model) handleResult(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 		m.showResult = false
 
 		return m, nil
+
+	default:
 	}
 
 	var cmd tea.Cmd
+
 	m.result, cmd = m.result.Update(msg)
 
 	return m, cmd
 }
 
 //revive:disable:cognitive-complexity // TODO: simplify.
 //revive:disable:cyclomatic // Ditto.
+//nolint:cyclop // Ditto.
 func (m model) handleBrowsing(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 	slog.Debug("browsing", "key", msg.String())
 
@@ -122,9 +129,12 @@ func (m model) handleBrowsing(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 		slog.Debug("focus command")
 
 		return m, m.command.Focus()
+
+	default:
 	}
 
 	var cmd tea.Cmd
+
 	m.list, cmd = m.list.Update(msg)
 
 	return m, cmd
@@ -147,6 +157,7 @@ func (m model) handleFiltering(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 	slog.Debug("filtering", "key", msg.String())
 
 	var cmd tea.Cmd
+
 	m.list, cmd = m.list.Update(msg)
 
 	return m, cmd