From be43f91cdac9e4462495b08f83fb86da9db94afc Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Tue, 8 Jul 2025 10:02:45 +0300 Subject: [PATCH] Replace obsolete ENV VAR VALUE with ENV VAR=VALUE Fixes these warnings: - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format --- 20/alpine3.21/Dockerfile | 6 +++--- 20/alpine3.22/Dockerfile | 6 +++--- 20/bookworm-slim/Dockerfile | 6 +++--- 20/bookworm/Dockerfile | 6 +++--- 20/bullseye-slim/Dockerfile | 6 +++--- 20/bullseye/Dockerfile | 6 +++--- 22/alpine3.21/Dockerfile | 4 ++-- 22/alpine3.22/Dockerfile | 4 ++-- 22/bookworm-slim/Dockerfile | 4 ++-- 22/bookworm/Dockerfile | 4 ++-- 22/bullseye-slim/Dockerfile | 4 ++-- 22/bullseye/Dockerfile | 4 ++-- 24/alpine3.21/Dockerfile | 4 ++-- 24/alpine3.22/Dockerfile | 4 ++-- 24/bookworm-slim/Dockerfile | 4 ++-- 24/bookworm/Dockerfile | 4 ++-- 24/bullseye-slim/Dockerfile | 4 ++-- 24/bullseye/Dockerfile | 4 ++-- Dockerfile-alpine.template | 4 ++-- Dockerfile-debian.template | 4 ++-- Dockerfile-slim.template | 4 ++-- README.md | 2 +- docs/BestPractices.md | 6 +++--- functions.sh | 2 +- genMatrix.js | 2 +- stackbrew.js | 2 +- update.sh | 4 ++-- 27 files changed, 57 insertions(+), 57 deletions(-) diff --git a/20/alpine3.21/Dockerfile b/20/alpine3.21/Dockerfile index e692931020..113bcf07e8 100644 --- a/20/alpine3.21/Dockerfile +++ b/20/alpine3.21/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.21 -ENV NODE_VERSION 20.19.4 +ENV NODE_VERSION=20.19.4 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -41,7 +41,7 @@ RUN addgroup -g 1000 node \ && export GNUPGHOME="$(mktemp -d)" \ # gpg keys listed at https://github.com/nodejs/node#release-keys && for key in \ - C0D6248439F1D5604AAFFB4021D900FFDB233756 \ + 5BE8A3F6C8A5C01D106C0AD820B1A390B168D356 \ DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \ 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/20/alpine3.22/Dockerfile b/20/alpine3.22/Dockerfile index d1b4bf4057..409100bba8 100644 --- a/20/alpine3.22/Dockerfile +++ b/20/alpine3.22/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.22 -ENV NODE_VERSION 20.19.4 +ENV NODE_VERSION=20.19.4 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -41,7 +41,7 @@ RUN addgroup -g 1000 node \ && export GNUPGHOME="$(mktemp -d)" \ # gpg keys listed at https://github.com/nodejs/node#release-keys && for key in \ - C0D6248439F1D5604AAFFB4021D900FFDB233756 \ + 5BE8A3F6C8A5C01D106C0AD820B1A390B168D356 \ DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \ 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/20/bookworm-slim/Dockerfile b/20/bookworm-slim/Dockerfile index 5484b6cb32..6137b92bc7 100644 --- a/20/bookworm-slim/Dockerfile +++ b/20/bookworm-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bookworm-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.4 +ENV NODE_VERSION=20.19.4 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -23,7 +23,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && export GNUPGHOME="$(mktemp -d)" \ # gpg keys listed at https://github.com/nodejs/node#release-keys && for key in \ - C0D6248439F1D5604AAFFB4021D900FFDB233756 \ + 5BE8A3F6C8A5C01D106C0AD820B1A390B168D356 \ DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \ 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/20/bookworm/Dockerfile b/20/bookworm/Dockerfile index d90dc6ac1a..84e06f9fcb 100644 --- a/20/bookworm/Dockerfile +++ b/20/bookworm/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.4 +ENV NODE_VERSION=20.19.4 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -20,7 +20,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ # gpg keys listed at https://github.com/nodejs/node#release-keys && set -ex \ && for key in \ - C0D6248439F1D5604AAFFB4021D900FFDB233756 \ + 5BE8A3F6C8A5C01D106C0AD820B1A390B168D356 \ DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \ 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/20/bullseye-slim/Dockerfile b/20/bullseye-slim/Dockerfile index c9b1c77fee..4f849986c1 100644 --- a/20/bullseye-slim/Dockerfile +++ b/20/bullseye-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bullseye-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.4 +ENV NODE_VERSION=20.19.4 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -23,7 +23,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && export GNUPGHOME="$(mktemp -d)" \ # gpg keys listed at https://github.com/nodejs/node#release-keys && for key in \ - C0D6248439F1D5604AAFFB4021D900FFDB233756 \ + 5BE8A3F6C8A5C01D106C0AD820B1A390B168D356 \ DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \ 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/20/bullseye/Dockerfile b/20/bullseye/Dockerfile index ad5120e8b3..e4bf012036 100644 --- a/20/bullseye/Dockerfile +++ b/20/bullseye/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.4 +ENV NODE_VERSION=20.19.4 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -20,7 +20,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ # gpg keys listed at https://github.com/nodejs/node#release-keys && set -ex \ && for key in \ - C0D6248439F1D5604AAFFB4021D900FFDB233756 \ + 5BE8A3F6C8A5C01D106C0AD820B1A390B168D356 \ DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 \ CC68F5A3106FF448322E48ED27F5E38D5B0A215F \ 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/alpine3.21/Dockerfile b/22/alpine3.21/Dockerfile index 4f7db331bd..aefe77de91 100644 --- a/22/alpine3.21/Dockerfile +++ b/22/alpine3.21/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.21 -ENV NODE_VERSION 22.18.0 +ENV NODE_VERSION=22.18.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/alpine3.22/Dockerfile b/22/alpine3.22/Dockerfile index 650f645c2f..3ab64626e3 100644 --- a/22/alpine3.22/Dockerfile +++ b/22/alpine3.22/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.22 -ENV NODE_VERSION 22.18.0 +ENV NODE_VERSION=22.18.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/bookworm-slim/Dockerfile b/22/bookworm-slim/Dockerfile index 7d89718959..dc390b51ce 100644 --- a/22/bookworm-slim/Dockerfile +++ b/22/bookworm-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bookworm-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.18.0 +ENV NODE_VERSION=22.18.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/22/bookworm/Dockerfile b/22/bookworm/Dockerfile index a2325fa729..b9acc2b7e7 100644 --- a/22/bookworm/Dockerfile +++ b/22/bookworm/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.18.0 +ENV NODE_VERSION=22.18.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/bullseye-slim/Dockerfile b/22/bullseye-slim/Dockerfile index a1a2c2a3c3..bf8eb9b0c8 100644 --- a/22/bullseye-slim/Dockerfile +++ b/22/bullseye-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bullseye-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.18.0 +ENV NODE_VERSION=22.18.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/22/bullseye/Dockerfile b/22/bullseye/Dockerfile index d91ac967f3..0d1f02748b 100644 --- a/22/bullseye/Dockerfile +++ b/22/bullseye/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.18.0 +ENV NODE_VERSION=22.18.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/alpine3.21/Dockerfile b/24/alpine3.21/Dockerfile index f6193eb878..2663aed191 100644 --- a/24/alpine3.21/Dockerfile +++ b/24/alpine3.21/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.21 -ENV NODE_VERSION 24.5.0 +ENV NODE_VERSION=24.5.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/alpine3.22/Dockerfile b/24/alpine3.22/Dockerfile index a63b14605f..d5c2166116 100644 --- a/24/alpine3.22/Dockerfile +++ b/24/alpine3.22/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.22 -ENV NODE_VERSION 24.5.0 +ENV NODE_VERSION=24.5.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/bookworm-slim/Dockerfile b/24/bookworm-slim/Dockerfile index ec2a819827..9371382261 100644 --- a/24/bookworm-slim/Dockerfile +++ b/24/bookworm-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bookworm-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.5.0 +ENV NODE_VERSION=24.5.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/24/bookworm/Dockerfile b/24/bookworm/Dockerfile index c546621cc2..8d93b8d191 100644 --- a/24/bookworm/Dockerfile +++ b/24/bookworm/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.5.0 +ENV NODE_VERSION=24.5.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/bullseye-slim/Dockerfile b/24/bullseye-slim/Dockerfile index 7778e7c24d..fc02c3f570 100644 --- a/24/bullseye-slim/Dockerfile +++ b/24/bullseye-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bullseye-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.5.0 +ENV NODE_VERSION=24.5.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/24/bullseye/Dockerfile b/24/bullseye/Dockerfile index bfd2a54f41..4229d90221 100644 --- a/24/bullseye/Dockerfile +++ b/24/bullseye/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.5.0 +ENV NODE_VERSION=24.5.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/Dockerfile-alpine.template b/Dockerfile-alpine.template index 832f637cc0..6aef5bcf81 100644 --- a/Dockerfile-alpine.template +++ b/Dockerfile-alpine.template @@ -1,6 +1,6 @@ FROM alpine:0.0 -ENV NODE_VERSION 0.0.0 +ENV NODE_VERSION=0.0.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -71,7 +71,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 0.0.0 +ENV YARN_VERSION=0.0.0 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/Dockerfile-debian.template b/Dockerfile-debian.template index 8dac02f898..411f949961 100644 --- a/Dockerfile-debian.template +++ b/Dockerfile-debian.template @@ -3,7 +3,7 @@ FROM buildpack-deps:name RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 0.0.0 +ENV NODE_VERSION=0.0.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -39,7 +39,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 0.0.0 +ENV YARN_VERSION=0.0.0 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/Dockerfile-slim.template b/Dockerfile-slim.template index 0fe02e764d..2abec536cd 100644 --- a/Dockerfile-slim.template +++ b/Dockerfile-slim.template @@ -3,7 +3,7 @@ FROM debian:name-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 0.0.0 +ENV NODE_VERSION=0.0.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -53,7 +53,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 0.0.0 +ENV YARN_VERSION=0.0.0 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/README.md b/README.md index fc778a31e5..b7ae36e486 100644 --- a/README.md +++ b/README.md @@ -123,7 +123,7 @@ simply use `ENV` to override `NPM_CONFIG_LOGLEVEL`. ```dockerfile FROM node -ENV NPM_CONFIG_LOGLEVEL info +ENV NPM_CONFIG_LOGLEVEL=info ... ``` diff --git a/docs/BestPractices.md b/docs/BestPractices.md index ad6dcc4e92..293df8af35 100644 --- a/docs/BestPractices.md +++ b/docs/BestPractices.md @@ -51,7 +51,7 @@ If you need to upgrade/downgrade `yarn` for a local install, you can do so by is ```Dockerfile FROM node:6 -ENV YARN_VERSION 1.16.0 +ENV YARN_VERSION=1.16.0 RUN yarn policies set-version $YARN_VERSION ``` @@ -61,7 +61,7 @@ RUN yarn policies set-version $YARN_VERSION ```Dockerfile FROM node:6 -ENV YARN_VERSION 1.16.0 +ENV YARN_VERSION=1.16.0 RUN curl -fSLO --compressed "https://yarnpkg.com/downloads/$YARN_VERSION/yarn-v$YARN_VERSION.tar.gz" \ && tar -xzf yarn-v$YARN_VERSION.tar.gz -C /opt/ \ @@ -75,7 +75,7 @@ If you're using an Alpine-based image, `curl` won't be present, so you'll need t ```Dockerfile FROM node:6-alpine -ENV YARN_VERSION 1.5.1 +ENV YARN_VERSION=1.5.1 RUN apk add --no-cache --virtual .build-deps-yarn curl \ && curl -fSLO --compressed "https://yarnpkg.com/downloads/$YARN_VERSION/yarn-v$YARN_VERSION.tar.gz" \ diff --git a/functions.sh b/functions.sh index 7c927cc081..444dc2f679 100755 --- a/functions.sh +++ b/functions.sh @@ -239,7 +239,7 @@ function get_full_version() { default_dockerfile="${version}/Dockerfile" fi - grep -m1 'ENV NODE_VERSION ' "${default_dockerfile}" | cut -d' ' -f3 + grep -m1 'ENV NODE_VERSION=' "${default_dockerfile}" | cut -d= -f2 } function get_major_minor_version() { diff --git a/genMatrix.js b/genMatrix.js index 9f57ea5096..1d592cca37 100644 --- a/genMatrix.js +++ b/genMatrix.js @@ -53,7 +53,7 @@ const getAffectedDockerfiles = (filesAdded, filesModified, filesRenamed) => { }; const getFullNodeVersionFromDockerfile = (file) => fs.readFileSync(file, 'utf8') - .match(/^ENV NODE_VERSION (\d*\.*\d*\.\d*)/m)[1]; + .match(/^ENV NODE_VERSION=(\d*\.*\d*\.\d*)/m)[1]; const getDockerfileMatrixEntry = (file) => { const [variant] = path.dirname(file).split(path.sep).slice(-1); diff --git a/stackbrew.js b/stackbrew.js index 58bec1daaf..77fa8b08a2 100755 --- a/stackbrew.js +++ b/stackbrew.js @@ -54,7 +54,7 @@ for (version of versions) { // Get full version from the first Dockerfile if (!fullversion) { let dockerfile = fs.readFileSync(dockerfilePath, 'utf-8') - fullversion = dockerfile.match(/ENV NODE_VERSION (?\d+)\.(?\d+)\.(?\d+)/) + fullversion = dockerfile.match(/ENV NODE_VERSION=(?\d+)\.(?\d+)\.(?\d+)/) } let tags = [ `${fullversion.groups.major}.${fullversion.groups.minor}.${fullversion.groups.patch}-${variant}`, diff --git a/update.sh b/update.sh index 88dcec1155..c30b6b3088 100755 --- a/update.sh +++ b/update.sh @@ -132,7 +132,7 @@ function update_node_version() { nodeVersion="${version}.${fullVersion:-0}" sed -Ei -e 's/^FROM (.*)/FROM '"$fromprefix"'\1/' "${dockerfile}-tmp" - sed -Ei -e 's/^(ENV NODE_VERSION ).*/\1'"${nodeVersion}"'/' "${dockerfile}-tmp" + sed -Ei -e 's/^(ENV NODE_VERSION)=.*/\1='"${nodeVersion}"'/' "${dockerfile}-tmp" # shellcheck disable=SC1004 new_line=' \\\ @@ -169,7 +169,7 @@ function update_node_version() { echo "${dockerfile} is already up to date!" else if [ "${SKIP}" != true ]; then - sed -Ei -e 's/^(ENV YARN_VERSION ).*/\1'"${yarnVersion}"'/' "${dockerfile}-tmp" + sed -Ei -e 's/^(ENV YARN_VERSION)=.*/\1='"${yarnVersion}"'/' "${dockerfile}-tmp" fi echo "${dockerfile} updated!" fi