Brillig: assertion failure message is lost when string is defined in variable

[asterite]

Aim

When this program is executed with nargo execute --force-brillig

fn main() {
    assert(false, "oops");
}

we get:

error: Assertion failed: oops
  ┌─ src/main.nr:2:12
  │
2 │     assert(false, "oops");
  │            -----

However, with this program:

fn main() {
    let oops = "oops";
    assert(false, oops);
}

we get:

error: Assertion failed
  ┌─ src/main.nr:3:12
  │
3 │     assert(false, oops);
  │            -----

Now how "oops" doesn't show up in the assertion failure message anymore.

This is blocking #10004

Expected Behavior

In the second case the assertion failure message "oops" should be shown.

Bug

The assertion message is lost.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

[asterite]

This also happens if the string is one or another based on a condition. It doesn't happen with other types, though, just with strings.

[asterite]

This can be partially fixed. See 47aef72 . There we handle the special case of Dynamic being a string type, and try to extract a constant string. Given that a string that is conditionally one value or another is unlikely to happen (their length must match) then it will almost always be a string that's known at compile-time, so that optimization will kick in.