fsm: mostly read peer.fsm.pConf

The logic is to use atomic.Value to store the pointer
and use fsm.lock Mutex for a write transaction in the fsm.pConf

Most fields are read-only, so they can be accessed an atomic copy via fsm.pConf.Load().Field.

Most write fields, state messages statistics and timer state update recvieve are written via atomic.

Author: nplanelcisco

pkg/config/oc/util.go

@@ -528,24 +528,24 @@ func NewPeerFromConfigStruct(pconf *Neighbor) *api.Peer {
 			AdminState:   admin_state,
 			Messages: &api.Messages{
 				Received: &api.Message{
-					Notification:   s.Messages.Received.Notification,
-					Update:         s.Messages.Received.Update,
-					Open:           s.Messages.Received.Open,
-					Keepalive:      s.Messages.Received.Keepalive,
-					Refresh:        s.Messages.Received.Refresh,
-					Discarded:      s.Messages.Received.Discarded,
-					Total:          s.Messages.Received.Total,
-					WithdrawUpdate: uint64(s.Messages.Received.WithdrawUpdate),
-					WithdrawPrefix: uint64(s.Messages.Received.WithdrawPrefix),
+					Notification:   pconf.State.Messages.Received.Notification,
+					Update:         pconf.State.Messages.Received.Update,
+					Open:           pconf.State.Messages.Received.Open,
+					Keepalive:      pconf.State.Messages.Received.Keepalive,
+					Refresh:        pconf.State.Messages.Received.Refresh,
+					Discarded:      pconf.State.Messages.Received.Discarded,
+					Total:          pconf.State.Messages.Received.Total,
+					WithdrawUpdate: uint64(pconf.State.Messages.Received.WithdrawUpdate),
+					WithdrawPrefix: uint64(pconf.State.Messages.Received.WithdrawPrefix),
 				},
 				Sent: &api.Message{
-					Notification: s.Messages.Sent.Notification,
-					Update:       s.Messages.Sent.Update,
-					Open:         s.Messages.Sent.Open,
-					Keepalive:    s.Messages.Sent.Keepalive,
-					Refresh:      s.Messages.Sent.Refresh,
-					Discarded:    s.Messages.Sent.Discarded,
-					Total:        s.Messages.Sent.Total,
+					Notification: pconf.State.Messages.Sent.Notification,
+					Update:       pconf.State.Messages.Sent.Update,
+					Open:         pconf.State.Messages.Sent.Open,
+					Keepalive:    pconf.State.Messages.Sent.Keepalive,
+					Refresh:      pconf.State.Messages.Sent.Refresh,
+					Discarded:    pconf.State.Messages.Sent.Discarded,
+					Total:        pconf.State.Messages.Sent.Total,
 				},
 			},
 			PeerAsn:         s.PeerAs,