[nrf noup] COV-177625: Fix double free

krishna T · krish2718 · commit a5a6a6dfdc2e · 2023-07-27T23:51:33.000+05:30
The scan result is always freed in the driver for both success and
failure cases, so, no need for wpa_supplicant to free in failure case.

Signed-off-by: Krishna T &lt;krishna.t@nordicsemi.no&gt;
diff --git a/src/drivers/driver_zephyr.c b/src/drivers/driver_zephyr.c
@@ -146,7 +146,6 @@ void wpa_drv_zep_event_proc_scan_res(struct zep_drv_if_ctx *if_ctx,
 
 	if (!tmp) {
 		wpa_printf(MSG_ERROR, "%s: Failed to realloc scan result array\n", __func__);
-		os_free(r);
 		goto err;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,6 @@ void wpa_drv_zep_event_proc_scan_res(struct zep_drv_if_ctx *if_ctx,`
`146`	`146`
`147`	`147`	`if (!tmp) {`
`148`	`148`	`wpa_printf(MSG_ERROR, "%s: Failed to realloc scan result array\n", __func__);`
`149`		`- os_free(r);`
`150`	`149`	`goto err;`
`151`	`150`	`}`
`152`	`151`