Merge pull request #353 from cygnusv/breakdance

Introduce additional method to post transcripts

Author: cygnusv

contracts/contracts/coordination/Coordinator.sol

@@ -398,7 +398,18 @@ contract Coordinator is Initializable, AccessControlDefaultAdminRulesUpgradeable
         return 40 + (dkgSize + 1) * BLS12381.G2_POINT_SIZE + threshold * BLS12381.G1_POINT_SIZE;
     }
 
+    /**
+     * @dev This method will be deprecated in the future. Use `publishTranscript` instead.
+     */
     function postTranscript(uint32 ritualId, bytes calldata transcript) external {
+        _postTranscript(ritualId, transcript);
+    }
+
+    function publishTranscript(uint32 ritualId, bytes calldata transcript) external {
+        _postTranscript(ritualId, transcript);
+    }
+
+    function _postTranscript(uint32 ritualId, bytes calldata transcript) internal {
         uint256 initialGasLeft = gasleft();
 
         Ritual storage ritual = storageRitual(ritualId);

tests/test_coordinator.py

@@ -251,10 +251,12 @@ def test_post_transcript(coordinator, nodes, initiator, erc20, fee_model, global
     threshold = coordinator.getThresholdForRitualSize(size)
     transcript = generate_transcript(size, threshold)
 
-    for node in nodes:
+    for i, node in enumerate(nodes):
         assert coordinator.getRitualState(0) == RitualState.DKG_AWAITING_TRANSCRIPTS
 
-        tx = coordinator.postTranscript(0, transcript, sender=node)
+        # Some nodes will use a different method to post the transcript to test both methods
+        post_transcript_fn = coordinator.postTranscript if i % 2 == 0 else coordinator.publishTranscript
+        tx = post_transcript_fn(0, transcript, sender=node)
 
         events = list(coordinator.TranscriptPosted.from_receipt(tx))
         assert events == [