Use sleef_q constants to avoid cast warnings

Author: juntyr

quaddtype/numpy_quaddtype/src/ops.hpp

@@ -1,6 +1,12 @@
 #include <sleef.h>
 #include <sleefquad.h>
 #include <cmath>
+#include <limits>
+
+// Quad Constants, generated with qutil
+#define QUAD_ZERO sleef_q(+0x0000000000000LL, 0x0000000000000000ULL, -16383)
+#define QUAD_ONE sleef_q(+0x1000000000000LL, 0x0000000000000000ULL, 0)
+#define QUAD_POS_INF sleef_q(+0x1000000000000LL, 0x0000000000000000ULL, 16384)
 
 // Unary Quad Operations
 typedef Sleef_quad (*unary_op_quad_def)(const Sleef_quad *);
@@ -20,8 +26,7 @@ quad_positive(const Sleef_quad *op)
 static inline Sleef_quad
 quad_sign(const Sleef_quad *op)
 {
-    Sleef_quad zero = Sleef_cast_from_doubleq1(0.0);
-    int32_t sign = Sleef_icmpq1(*op, zero);
+    int32_t sign = Sleef_icmpq1(*op, QUAD_ZERO);
     // sign(x=NaN) = x; otherwise sign(x) in { -1.0; 0.0; +1.0 }
     return Sleef_iunordq1(*op, *op) ? *op : Sleef_cast_from_int64q1(sign);
 }
@@ -287,27 +292,23 @@ quad_signbit(const Sleef_quad *op)
 {
     // FIXME @juntyr or @SwayamInSync: replace with binary implementation
     //  once we test big and little endian in CI
-    Sleef_quad zero = Sleef_cast_from_doubleq1(0.0);
-    Sleef_quad one = Sleef_cast_from_doubleq1(1.0);
-    Sleef_quad one_signed = Sleef_copysignq1(one, *op);
+    Sleef_quad one_signed = Sleef_copysignq1(QUAD_ONE, *op);
     // signbit(x) = 1 iff copysign(1, x) == -1
-    return Sleef_icmpltq1(one_signed, zero);
+    return Sleef_icmpltq1(one_signed, QUAD_ZERO);
 }
 
 static inline npy_bool
 quad_isfinite(const Sleef_quad *op)
 {
     // isfinite(x) = abs(x) < inf
-    Sleef_quad inf = Sleef_cast_from_doubleq1(std::numeric_limits<double>::infinity());
-    return Sleef_icmpltq1(Sleef_fabsq1(*op), inf);
+    return Sleef_icmpltq1(Sleef_fabsq1(*op), QUAD_POS_INF);
 }
 
 static inline npy_bool
 quad_isinf(const Sleef_quad *op)
 {
     // isinf(x) = abs(x) == inf
-    Sleef_quad inf = Sleef_cast_from_doubleq1(std::numeric_limits<double>::infinity());
-    return Sleef_icmpeqq1(Sleef_fabsq1(*op), inf);
+    return Sleef_icmpeqq1(Sleef_fabsq1(*op), QUAD_POS_INF);
 }
 
 static inline npy_bool

quaddtype/tests/test_quaddtype.py

@@ -97,11 +97,11 @@ def test_array_aminmax(op, a, b):
     np.testing.assert_array_equal(np.array(quad_res).astype(float), float_res)
 
 
-@pytest.mark.parametrize("op,nop", [("neg", "negative"), ("pos", "positive"), ("abs", "absolute"), (None, "sign"), (None, "signbit"), (None, "isfinite"), (None, "isinf"), (None, "isnan")])
+@pytest.mark.parametrize("op", ["negative", "positive", "absolute", "sign", "signbit", "isfinite", "isinf", "isnan"])
 @pytest.mark.parametrize("val", ["3.0", "-3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
-def test_unary_ops(op, nop, val):
-    op_func = None if op is None else getattr(operator, op)
-    nop_func = getattr(np, nop)
+def test_unary_ops(op, val):
+    op_func = dict(negative=operator.neg, positive=operator.pos, absolute=operator.abs).get(op, None)
+    nop_func = getattr(np, op)
 
     quad_val = QuadPrecision(val)
     float_val = float(val)