From 69f1c6f41fa9c165c8399d98404ef0dc8df93c4d Mon Sep 17 00:00:00 2001 From: Thai Phan Date: Thu, 22 May 2025 14:28:02 +1200 Subject: [PATCH] ASoC: fsl_xcvr: Fix bug in fsl_xcvr_runtime_suspend In fsl_xcvr_runtime_suspend, we may return 0 for success even if regmap_update_bits failed. So fix it to return the error instead. Signed-off-by: Thai Phan --- sound/soc/fsl/fsl_xcvr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 46a8f0135701..a6d1238a2786 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -1502,8 +1502,10 @@ static __maybe_unused int fsl_xcvr_runtime_suspend(struct device *dev) ret = regmap_update_bits(xcvr->regmap, FSL_XCVR_EXT_CTRL, FSL_XCVR_EXT_CTRL_CORE_RESET, FSL_XCVR_EXT_CTRL_CORE_RESET); - if (ret < 0) + if (ret < 0) { dev_err(dev, "Failed to assert M0+ core: %d\n", ret); + return ret; + } } regcache_cache_only(xcvr->regmap, true);