fix: deploy factory with separate implementations to avoid initcode size limit

- Update AgentRegistryFactory constructor to accept pre-deployed implementation addresses
- Modify deployment scripts to deploy implementations separately before factory
- This avoids 'max initcode size exceeded' errors when deploying the factory

Author: nxt3d

script/DeployAgentRegistry.s.sol

@@ -90,6 +90,7 @@ contract DeployAgentRegistryWithRoles is Script {
 /**
  * @title DeployAgentRegistryFactory
  * @dev Deployment script for AgentRegistryFactory contract (EIP-1167 minimal clones)
+ *      Deploys implementations separately to avoid initcode size limits
  * 
  * Usage:
  *   forge script script/DeployAgentRegistry.s.sol:DeployAgentRegistryFactory --rpc-url $SEPOLIA_RPC_URL --broadcast --verify
@@ -99,29 +100,49 @@ contract DeployAgentRegistryWithRoles is Script {
  *   - ETHERSCAN_API_KEY: API key for contract verification (optional)
  */
 contract DeployAgentRegistryFactory is Script {
-    function run() external returns (AgentRegistryFactory factory) {
+    function run() external returns (AgentRegistryFactory factory, address registryImpl, address registrarImpl) {
         uint256 deployerPrivateKey = vm.envUint("DEPLOYER_PRIVATE_KEY");
         address deployer = vm.addr(deployerPrivateKey);
 
-        console.log("Deploying AgentRegistryFactory...");
+        console.log("Deploying AgentRegistryFactory with separate implementations...");
         console.log("Deployer address:", deployer);
 
         vm.startBroadcast(deployerPrivateKey);
 
-        factory = new AgentRegistryFactory();
+        // Deploy implementations separately to avoid initcode size limits
+        console.log("Deploying AgentRegistry implementation...");
+        AgentRegistry registryImplContract = new AgentRegistry();
+        registryImpl = address(registryImplContract);
+        console.log("Registry Implementation deployed at:", registryImpl);
+
+        console.log("Deploying AgentRegistrar implementation...");
+        // Deploy registrar implementation with dummy values (will be overwritten on clone init)
+        AgentRegistrar registrarImplContract = new AgentRegistrar(
+            AgentRegistry(registryImpl),
+            0,
+            0,
+            deployer
+        );
+        registrarImpl = address(registrarImplContract);
+        console.log("Registrar Implementation deployed at:", registrarImpl);
+
+        console.log("Deploying AgentRegistryFactory...");
+        factory = new AgentRegistryFactory(registryImpl, registrarImpl);
 
         vm.stopBroadcast();
 
-        console.log("AgentRegistryFactory deployed at:", address(factory));
-        console.log("Registry Implementation:", factory.registryImplementation());
-        console.log("Registrar Implementation:", factory.registrarImplementation());
+        console.log("");
+        console.log("=== Deployment Summary ===");
+        console.log("AgentRegistryFactory:", address(factory));
+        console.log("Registry Implementation:", registryImpl);
+        console.log("Registrar Implementation:", registrarImpl);
         console.log("");
         console.log("To deploy registry + registrar:");
         console.log("  factory.deploy(admin, mintPrice, maxSupply)");
         console.log("To deploy registry only:");
         console.log("  factory.deployRegistry(admin)");
 
-        return factory;
+        return (factory, registryImpl, registrarImpl);
     }
 }
 
@@ -152,8 +173,17 @@ contract DeployRegistryAndRegistrar is Script {
 
         vm.startBroadcast(deployerPrivateKey);
 
+        // Deploy implementations separately to avoid initcode size limits
+        AgentRegistry registryImpl = new AgentRegistry();
+        AgentRegistrar registrarImpl = new AgentRegistrar(
+            registryImpl,
+            0,
+            0,
+            deployer
+        );
+
         // Deploy factory
-        factory = new AgentRegistryFactory();
+        factory = new AgentRegistryFactory(address(registryImpl), address(registrarImpl));
 
         // Deploy registry + registrar pair
         (registry, registrar) = factory.deploy(deployer, mintPrice, maxSupply);
@@ -199,8 +229,17 @@ contract DeployRegistryOnly is Script {
 
         vm.startBroadcast(deployerPrivateKey);
 
+        // Deploy implementations separately to avoid initcode size limits
+        AgentRegistry registryImpl = new AgentRegistry();
+        AgentRegistrar registrarImpl = new AgentRegistrar(
+            registryImpl,
+            0,
+            0,
+            deployer
+        );
+
         // Deploy factory
-        factory = new AgentRegistryFactory();
+        factory = new AgentRegistryFactory(address(registryImpl), address(registrarImpl));
 
         // Deploy registry only
         registry = factory.deploy(deployer);

src/AgentRegistryFactory.sol

@@ -22,13 +22,13 @@ contract AgentRegistryFactory {
     /// @notice Emitted when a new AgentRegistrar clone is deployed
     /// @param registrar The address of the newly deployed registrar clone
     /// @param registry The registry the registrar mints to
-    /// @param owner The owner of the registrar
-    event RegistrarDeployed(address indexed registrar, address indexed registry, address indexed owner);
+    /// @param admin The admin of the registrar (receives ADMIN_ROLE, DEFAULT_ADMIN_ROLE, and MINTER_ROLE)
+    event RegistrarDeployed(address indexed registrar, address indexed registry, address indexed admin);
 
     /// @notice Emitted when both registry and registrar are deployed together
     /// @param registry The address of the registry
     /// @param registrar The address of the registrar
-    /// @param admin The admin/owner address
+    /// @param admin The admin address (receives all roles in both contracts)
     event RegistryAndRegistrarDeployed(address indexed registry, address indexed registrar, address indexed admin);
 
     /* --- State Variables --- */
@@ -56,17 +56,15 @@ contract AgentRegistryFactory {
 
     /* --- Constructor --- */
 
-    /// @notice Deploy the factory with new implementation contracts
-    /// @dev Creates AgentRegistry and AgentRegistrar implementations for cloning
-    constructor() {
-        registryImplementation = address(new AgentRegistry());
-        // Deploy registrar implementation with dummy values (will be overwritten on clone init)
-        registrarImplementation = address(new AgentRegistrar(
-            AgentRegistry(registryImplementation),
-            0,
-            0,
-            address(this)
-        ));
+    /// @notice Deploy the factory with pre-deployed implementation contracts
+    /// @param _registryImplementation The address of the AgentRegistry implementation
+    /// @param _registrarImplementation The address of the AgentRegistrar implementation
+    /// @dev Deploy implementations separately first to avoid "max initcode size exceeded" errors
+    constructor(address _registryImplementation, address _registrarImplementation) {
+        require(_registryImplementation != address(0), "Invalid registry implementation");
+        require(_registrarImplementation != address(0), "Invalid registrar implementation");
+        registryImplementation = _registryImplementation;
+        registrarImplementation = _registrarImplementation;
     }
 
     /* --- Registry Deployment --- */
@@ -165,27 +163,27 @@ contract AgentRegistryFactory {
     /// @param registry The AgentRegistry to mint to
     /// @param mintPrice Price per mint in wei (0 = free)
     /// @param maxSupply Maximum supply (0 = unlimited)
-    /// @param owner Owner of the registrar
+    /// @param admin Admin of the registrar (receives ADMIN_ROLE, DEFAULT_ADMIN_ROLE, and MINTER_ROLE)
     /// @return registrar The address of the newly deployed registrar
     function deployRegistrar(
         AgentRegistry registry,
         uint256 mintPrice,
         uint256 maxSupply,
-        address owner
+        address admin
     ) external returns (address registrar) {
         registrar = registrarImplementation.clone();
-        AgentRegistrar(payable(registrar)).initialize(registry, mintPrice, maxSupply, owner);
+        AgentRegistrar(payable(registrar)).initialize(registry, mintPrice, maxSupply, admin);
 
         deployedRegistrars.push(registrar);
         isDeployedRegistrar[registrar] = true;
 
-        emit RegistrarDeployed(registrar, address(registry), owner);
+        emit RegistrarDeployed(registrar, address(registry), admin);
     }
 
     /* --- Combined Deployment --- */
 
     /// @notice Deploy both a registry and registrar together
-    /// @param admin The admin for the registry and owner of the registrar
+    /// @param admin The admin for the registry and registrar (receives all roles in both contracts)
     /// @param mintPrice Price per mint in wei (0 = free)
     /// @param maxSupply Maximum supply (0 = unlimited)
     /// @return registry The address of the deployed registry
@@ -233,7 +231,7 @@ contract AgentRegistryFactory {
     }
 
     /// @notice Deploy both a registry and registrar together with a name
-    /// @param admin The admin for the registry and owner of the registrar
+    /// @param admin The admin for the registry and registrar (receives all roles in both contracts)
     /// @param mintPrice Price per mint in wei (0 = free)
     /// @param maxSupply Maximum supply (0 = unlimited)
     /// @param name The name for the registry (stored as ERC-8049 contract metadata)
@@ -286,7 +284,7 @@ contract AgentRegistryFactory {
     }
 
     /// @notice Deploy both a registry and registrar with deterministic addresses
-    /// @param admin The admin for the registry and owner of the registrar
+    /// @param admin The admin for the registry and registrar (receives all roles in both contracts)
     /// @param mintPrice Price per mint in wei (0 = free)
     /// @param maxSupply Maximum supply (0 = unlimited)
     /// @param registrySalt Salt for registry address
@@ -338,7 +336,7 @@ contract AgentRegistryFactory {
     }
 
     /// @notice Deploy both a registry and registrar with deterministic addresses and a name
-    /// @param admin The admin for the registry and owner of the registrar
+    /// @param admin The admin for the registry and registrar (receives all roles in both contracts)
     /// @param mintPrice Price per mint in wei (0 = free)
     /// @param maxSupply Maximum supply (0 = unlimited)
     /// @param registrySalt Salt for registry address