bug fix, add fallback for actor attr when winapi error

Author: ny

ff_draw/mem/actor.py

@@ -3,7 +3,7 @@
 import typing
 import glm
 from nylib.utils.win32 import memory as ny_mem
-from .utils import direct_mem_property
+from .utils import direct_mem_property, WinAPIError
 
 if typing.TYPE_CHECKING:
     from . import XivMem
@@ -26,8 +26,13 @@ def actor(self):
 
     def __iter__(self):
         """id,param,remain,source_id"""
-        for i in range(30):
-            yield status_struct.unpack(ny_mem.read_bytes(self.handle, self.address + 8 + (i * status_struct.size), status_struct.size))
+        try:
+            for i in range(30):
+                yield status_struct.unpack(
+                    ny_mem.read_bytes(self.handle, self.address + 8 + (i * status_struct.size), status_struct.size)
+                )
+        except WinAPIError:
+            pass
 
     def _iter_filter(self, status_id: int, source_id=0):
         for status_id_, param, remain, source_id_ in self:
@@ -105,7 +110,10 @@ def __init__(self, handle, address):
 
     @property
     def name(self):
-        return ny_mem.read_string(self.handle, self.address + self.offsets.name, 68)
+        try:
+            return ny_mem.read_string(self.handle, self.address + self.offsets.name, 68)
+        except WinAPIError:
+            return ''
 
     id = direct_mem_property(ctypes.c_uint)
     base_id = direct_mem_property(ctypes.c_uint)
@@ -132,17 +140,28 @@ def pos(self):
 
     @property
     def target_id(self):
-        return ny_mem.read_uint(self.handle, self.address + (self.offsets.pc_target_id if self.actor_type == 1 else self.offsets.b_npc_target_id))
+        try:
+            return ny_mem.read_uint(self.handle, self.address + (
+                self.offsets.pc_target_id if self.actor_type == 1 else self.offsets.b_npc_target_id
+            ))
+        except WinAPIError:
+            return 0
 
     @property
     def can_select(self):
-        if ny_mem.read_byte(self.handle, self.address + self.offsets.status_flag) & 0b110 != 0b110: return False
-        return ny_mem.read_uint(self.handle, self.address + self.offsets.hide_flag) >> 11 == 0
+        try:
+            if ny_mem.read_byte(self.handle, self.address + self.offsets.status_flag) & 0b110 != 0b110: return False
+            return ny_mem.read_uint(self.handle, self.address + self.offsets.hide_flag) >> 11 == 0
+        except WinAPIError:
+            return False
 
     @property
     def is_visible(self):
-        p_draw_object = ny_mem.read_address(self.handle, self.address + self.offsets.draw_object)
-        return ny_mem.read_byte(self.handle, p_draw_object + 0x88) & 1
+        try:
+            p_draw_object = ny_mem.read_address(self.handle, self.address + self.offsets.draw_object)
+            return ny_mem.read_byte(self.handle, p_draw_object + 0x88) & 1 > 0
+        except WinAPIError:
+            return False
 
     @property
     def status(self):
@@ -157,7 +176,8 @@ def __init__(self, main: 'XivMem'):
         self.handle = main.handle
         self.base_address = main.scanner.find_point('4c ? ? * * * * 89 ac cb')[0]
         self.sorted_table_address = self.base_address + main.scanner.find_val('4e ? ? ? * * * * 41 ? ? ? 3b ? 73')[0]
-        self.sorted_count_address = self.base_address + main.scanner.find_val('44 ? ? * * * * 45 ? ? 41 ? ? ? 48 ? ? 78')[0]
+        self.sorted_count_address = self.base_address + \
+                                    main.scanner.find_val('44 ? ? * * * * 45 ? ? 41 ? ? ? 48 ? ? 78')[0]
         self.me_ptr = main.scanner.find_point('48 ? ? * * * * 49 39 87')[0]
         if main.game_version >= (6, 3, 0):
             Actor.offsets = ActorOffsets630
@@ -204,7 +224,9 @@ def get_actor_by_id(self, actor_id):
                 # error occurred, maybe just game update
                 return
             aid = a.id
-            if aid < actor_id:
+            if not aid:
+                continue
+            elif aid < actor_id:
                 left = idx + 1
             elif aid > actor_id:
                 right = idx - 1

ff_draw/mem/utils.py

@@ -3,24 +3,31 @@
 import typing
 
 from nylib.utils.win32 import memory as ny_mem
+from nylib.utils.win32.exception import WinAPIError
 
 _addr_size = ctypes.sizeof(ctypes.c_void_p)
 _T = typing.TypeVar('_T')
 
 
 class direct_mem_property:
-    def __init__(self, _type, offset_key=None):
+    def __init__(self, _type, offset_key=None, default=0):
         self.type = _type
         self.offset_key = offset_key
+        self.default = default
 
     def __set_name__(self, owner, name):
         if not self.offset_key:
             self.offset_key = name
 
     def __get__(self, instance, owner) -> 'float | int | direct_mem_property':
         if instance is None: return self
-        if not (addr := instance.address): raise AttributeError('Instance is None')
-        return ny_mem.read_memory(instance.handle, self.type, addr + getattr(instance.offsets, self.offset_key)).value
+        if not (addr := instance.address): return self.default
+        try:
+            return ny_mem.read_memory(
+                instance.handle, self.type,
+                addr + getattr(instance.offsets, self.offset_key)).value
+        except WinAPIError:
+            return self.default
 
 
 def get_hwnd(pid):
@@ -43,7 +50,8 @@ def get_game_version_info(file_name):
     with open(file_name, 'rb') as f: base_data = f.read()
     match = re.search(r"/\*{5}ff14\*{6}rev\d+_(\d{4})/(\d{2})/(\d{2})".encode(), base_data)
     game_build_date: str = f"{match.group(1).decode()}.{match.group(2).decode()}.{match.group(3).decode()}.0000.0000"
-    match = re.search(r'(\d{3})\\trunk\\prog\\client\\Build\\FFXIVGame\\x64-Release\\ffxiv_dx11.pdb'.encode(), base_data)
+    match = re.search(r'(\d{3})\\trunk\\prog\\client\\Build\\FFXIVGame\\x64-Release\\ffxiv_dx11.pdb'.encode(),
+                      base_data)
     game_version: tuple[int, int, int] = tuple(b - 48 for b in match.group(1))
     return game_version, game_build_date
 

ff_draw/sniffer/message_dump.py

@@ -55,7 +55,7 @@ def parse(cls, file_name: pathlib.Path | str, pno_dir: pathlib.Path | str):
             zone_client_pno_map = simple.load_pno_map(pno_dir / 'ZoneClientIpc.csv', game_build_date, enums.ZoneClient)
 
             while True:
-                if not (header_bytes := buf.read(20)): break
+                if not (header_bytes := buf.read(24)): break
 
                 scope, proto_no, fix_value, source_id, size, timestamp_ms = struct.unpack(b'BHiIIQ', header_bytes)
                 data = buf.read(size)