Skip to content

Commit fdbee7b

Browse files
authored
Merge pull request #1036 from oBusk/copilot/move-about-pages-to-folder
Move about pages to `-/about` to prevent wildcard route collision
2 parents 908d749 + 7e408d0 commit fdbee7b

File tree

8 files changed

+10
-11
lines changed

8 files changed

+10
-11
lines changed

src/app/about/_page/assets/external-services.darkmode.png renamed to src/app/-/about/_page/assets/external-services.darkmode.png

File renamed without changes.

src/app/about/_page/assets/external-services.lightmode.png renamed to src/app/-/about/_page/assets/external-services.lightmode.png

File renamed without changes.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export default function AboutPage() {
2929
<Code>libnpmdiff</Code>
3030
</ExternalLink>{" "}
3131
package to perform a diff between the packages you chose. We
32-
then visualize the differance.
32+
then visualize the difference.
3333
</p>
3434
<Heading>Redirection</Heading>
3535
<p>
@@ -63,7 +63,7 @@ export default function AboutPage() {
6363
<ExternalLink href="https://packagephobia.com">
6464
packagephobia
6565
</ExternalLink>{" "}
66-
to give an overview of the differances between the two, measured
66+
to give an overview of the differences between the two, measured
6767
in install and bundle size.
6868
</p>
6969
</Stack>

src/app/-/about/source-trust/opengraph-image.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @next/next/no-img-element */
21
import { ImageResponse } from "next/og";
32
import { readFile } from "node:fs/promises";
43
import { join } from "node:path";

src/app/_layout/Header/Header.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@ const Header = forwardRef<HTMLElement, HeaderProps>(
4040
fallback={
4141
<>
4242
<NavLinkFallback
43-
href="/about"
43+
href="/-/about"
4444
className="rounded-r-none border-r-0"
4545
>
4646
About
4747
</NavLinkFallback>
4848
<NavLinkFallback
49-
href="/about/api"
49+
href="/-/about/api"
5050
className="rounded-none border-r-0"
5151
>
5252
API
@@ -61,13 +61,13 @@ const Header = forwardRef<HTMLElement, HeaderProps>(
6161
}
6262
>
6363
<NavLink
64-
href="/about"
64+
href="/-/about"
6565
className="rounded-r-none border-r-0"
6666
>
6767
About
6868
</NavLink>
6969
<NavLink
70-
href="/about/api"
70+
href="/-/about/api"
7171
className="rounded-none border-r-0"
7272
>
7373
API

src/app/_layout/Header/MobileMenu.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ const MobileMenu = forwardRef<HTMLDivElement, MobileMenuProps>((props, ref) => {
4949
fallback={
5050
<>
5151
<NavLinkFallback
52-
href="/about"
52+
href="/-/about"
5353
className="w-full justify-start"
5454
onClick={closeMenu}
5555
>
5656
About
5757
</NavLinkFallback>
5858
<NavLinkFallback
59-
href="/about/api"
59+
href="/-/about/api"
6060
className="w-full justify-start"
6161
onClick={closeMenu}
6262
>
@@ -73,14 +73,14 @@ const MobileMenu = forwardRef<HTMLDivElement, MobileMenuProps>((props, ref) => {
7373
}
7474
>
7575
<NavLink
76-
href="/about"
76+
href="/-/about"
7777
className="w-full justify-start"
7878
onClick={closeMenu}
7979
>
8080
About
8181
</NavLink>
8282
<NavLink
83-
href="/about/api"
83+
href="/-/about/api"
8484
className="w-full justify-start"
8585
onClick={closeMenu}
8686
>

0 commit comments

Comments
 (0)