Skip to content

Commit c7dc1ed

Browse files
edwintorokrgrinberg
authored andcommitted
fix(dune): enable dune rpc by default
Dune build --watch integration relies on dune RPC, but this was only enabled during tests. Enable Dune integration by default instead, as suggested by @rgrinberg. Fixes #690 Signed-off-by: Edwin Török <[email protected]> ps-id: 458AE51C-44DA-4CA6-B457-F0431E27FA3E
1 parent 86f0f7d commit c7dc1ed

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

CHANGES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# 1.11.3
2+
3+
## Fixes
4+
5+
- Enable dune rpc integration by default (#691, fixes #690)
6+
17
# 1.11.2
28

39
## Fixes

ocaml-lsp-server/src/dune.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -713,10 +713,10 @@ let create workspaces (client_capabilities : ClientCapabilities.t) diagnostics
713713

714714
let create workspaces (client_capabilities : ClientCapabilities.t) diagnostics
715715
progress document_store ~log =
716-
if inside_test then
716+
if inside_test then ref Closed
717+
else
717718
create workspaces client_capabilities diagnostics progress document_store
718719
~log
719-
else ref Closed
720720

721721
let run_loop t =
722722
Fiber.repeat_while ~init:() ~f:(fun () ->

0 commit comments

Comments
 (0)