hotfix bug in crw_in_polygon with non-default initPos and missing cartesianCRS; fixes 277

Author: chrisholbrook

DESCRIPTION

@@ -2,8 +2,8 @@ Package: glatos
 Type: Package
 Title: A package for the Great Lakes Acoustic Telemetry Observation System
 Description: Functions useful to members of the Great Lakes Acoustic Telemetry Observation System https://glatos.org; many more broadly relevant to simulating, processing, analysing, and visualizing acoustic telemetry data.
-Version: 0.9.4
-Date: 2026-02-13
+Version: 0.9.5
+Date: 2026-03-25
 Depends: R (>= 3.6.0)
 Imports:
 		av,

NEWS.md

@@ -1,5 +1,18 @@
 ----
 
+# glatos 0.9.5 (2026-03-25)
+
+
+### Bug fixes
+
+- Fixed bug in `crw_in_polygon()` that caused failure with error with 
+non-default initPos and missing cartesianCRS arguments when crs of input 
+polyg is cartesian.
+  - fixes [issue #277](https://github.com/ocean-tracking-network/glatos/issues/277)
+
+
+----
+
 # glatos 0.9.4 (2026-02-13)
 
 

R/sim-crw_in_polygon.r

@@ -217,7 +217,7 @@ crw_in_polygon <- function(
   crs_cartesian <- sf::st_crs(cartesianCRS)
 
   # Set crs_cartesian = crs_input if Cartesian and cartesianCRS missing
-  if (is.na(crs_cartesian) & isTRUE(crs_in$IsGeographic)) {
+  if (is.na(crs_cartesian) & isFALSE(crs_in$IsGeographic)) {
     crs_cartesian <- crs_in
   }
 

tests/testthat/_snaps/crw_in_polygon.md

@@ -91,3 +91,21 @@
       5 POINT (-87.83445 48.69117)
       6 POINT (-87.95955 48.72632)
 
+# sf input, sf output gives expected result with non-default init_pos and missing cartesianCRS (issue 277)
+
+    Code
+      sfin_sfout
+    Output
+      Simple feature collection with 6 features and 0 fields
+      Geometry type: POINT
+      Dimension:     XY
+      Bounding box:  xmin: 832597 ymin: 1024974 xmax: 857297.5 ymax: 1056453
+      Projected CRS: NAD83 / Great Lakes and St Lawrence Albers
+                        geometry
+      1   POINT (832597 1048244)
+      2 POINT (838307.6 1056453)
+      3 POINT (847638.5 1052857)
+      4 POINT (853177.5 1044531)
+      5 POINT (854868.4 1034675)
+      6 POINT (857297.5 1024974)
+

tests/testthat/test-crw_in_polygon.r

@@ -158,6 +158,30 @@ test_that("sf input, sf output gives expected result", {
 })
 
 
+test_that("sf input, sf output gives expected result with non-default init_pos and missing cartesianCRS (issue 277)", {
+  set.seed(30)
+  
+  expect_s3_class(
+    sfin_sfout <- crw_in_polygon(
+      polyg = sf::st_transform(great_lakes_polygon, crs = 3175),
+      theta = c(0, 25),
+      stepLen = 10000,
+      initPos = c(832597, 1048244),
+      nsteps = 5,
+      sp_out = TRUE,
+      show_progress = FALSE
+    ),
+    "sf"
+  )
+  
+  expect_equal(dim(sfin_sfout), c(6, 1))
+  
+  expect_snapshot(
+    sfin_sfout
+  )
+})
+
+
 ##### TEST NON-EXPORTED FUNCTIONS ####
 
 test_that("internal function crosses_boundary gives expected result", {