Merge pull request #23 from octet-stream/fix/update-delete-many

Author: octet-stream

.changeset/cute-regions-wash.md

@@ -0,0 +1,5 @@
+---
+"better-auth-mikro-orm": patch
+---
+
+Use `nativeDelete` and `nativeUpdate` ORM methods for `updateMany`/`deleteMany`. However, this change mean that Identity Map won't be updated after `deleteMany` and `updateMany` methods.

src/adapter.ts

@@ -145,23 +145,11 @@ export const mikroOrmAdapter = (
         async updateMany({model, where, update}) {
           const metadata = getEntityMetadata(model)
 
-          const rows = await orm.em.find(
+          return orm.em.nativeUpdate(
             metadata.class,
-
             normalizeWhereClauses(metadata, where),
-
-            {
-              fields: ["id"]
-            }
-          )
-
-          rows.forEach(entity =>
-            orm.em.assign(entity, normalizeInput(metadata, update as any))
+            normalizeInput(metadata, update as any)
           )
-
-          await orm.em.flush()
-
-          return rows.length
         },
 
         async delete({model, where}) {
@@ -185,19 +173,10 @@ export const mikroOrmAdapter = (
         async deleteMany({model, where}) {
           const metadata = getEntityMetadata(model)
 
-          const [rows, count] = await orm.em.findAndCount(
+          return orm.em.nativeDelete(
             metadata.class,
-
-            normalizeWhereClauses(metadata, where),
-
-            {
-              fields: ["id"]
-            }
+            normalizeWhereClauses(metadata, where)
           )
-
-          await orm.em.removeAndFlush(rows)
-
-          return count
         }
       }
     }

tests/node/adapter.test.ts

@@ -329,7 +329,7 @@ suite("updateMany", () => {
   test("updates matched rows", async () => {
     const [user1, user2, user3] = await randomUsers.createAndFlushMany(3)
 
-    const actual = await adapter.updateMany({
+    const affected = await adapter.updateMany({
       model: "user",
       where: [
         {
@@ -344,12 +344,17 @@ suite("updateMany", () => {
       }
     })
 
-    expect(actual).toBe(2)
-    expect([
-      user1.emailVerified,
-      user2.emailVerified,
-      user3.emailVerified
-    ]).toMatchObject([true, false, true])
+    expect(affected).toBe(2)
+
+    const users = await orm.em.find(entities.User, {
+      id: {$in: [user1.id, user2.id, user3.id]}
+    })
+
+    expect(users.map(({emailVerified}) => emailVerified)).toMatchObject([
+      true,
+      false,
+      true
+    ])
   })
 
   test("does not clear Identity Map", async () => {