Skip to content

Commit 868d815

Browse files
authored
MRG: Merge pull request #189 from octue/fix/ensure-tests-always-use-test-result-modifier
Ensure tests always receive test result modifier on Windows
2 parents 4f48164 + 3f076d6 commit 868d815

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
setup(
1919
name="octue",
20-
version="0.1.23", # Ensure all requirements files containing octue are updated, too (e.g. docs build).
20+
version="0.1.24", # Ensure all requirements files containing octue are updated, too (e.g. docs build).
2121
py_modules=["cli"],
2222
install_requires=[
2323
"click>=7.1.2",

tests/__init__.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
import os
2-
import unittest
3-
4-
from octue.cloud.emulators import GoogleCloudStorageEmulatorTestResultModifier
52

63

74
TESTS_DIR = os.path.dirname(__file__)
85
TEST_PROJECT_NAME = os.environ["TEST_PROJECT_NAME"]
96
TEST_BUCKET_NAME = "octue-test-bucket"
10-
11-
test_result_modifier = GoogleCloudStorageEmulatorTestResultModifier(default_bucket_name=TEST_BUCKET_NAME)
12-
setattr(unittest.TestResult, "startTestRun", test_result_modifier.startTestRun)
13-
setattr(unittest.TestResult, "stopTestRun", test_result_modifier.stopTestRun)

tests/base.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55
import uuid
66
from tempfile import TemporaryDirectory, gettempdir
77

8+
from octue.cloud.emulators import GoogleCloudStorageEmulatorTestResultModifier
89
from octue.logging_handlers import apply_log_handler
910
from octue.mixins import MixinBase, Pathable
1011
from octue.resources import Datafile, Dataset, Manifest
12+
from tests import TEST_BUCKET_NAME
1113

1214

1315
logger = logging.getLogger(__name__)
@@ -23,6 +25,10 @@ class BaseTestCase(unittest.TestCase):
2325
- sets a path to the test data directory
2426
"""
2527

28+
test_result_modifier = GoogleCloudStorageEmulatorTestResultModifier(default_bucket_name=TEST_BUCKET_NAME)
29+
setattr(unittest.TestResult, "startTestRun", test_result_modifier.startTestRun)
30+
setattr(unittest.TestResult, "stopTestRun", test_result_modifier.stopTestRun)
31+
2632
def setUp(self):
2733
# Set up paths to the test data directory and to the app templates directory
2834
root_dir = os.path.dirname(os.path.abspath(__file__))

0 commit comments

Comments
 (0)