[FIX] charts: hierarchical charts should show formatted labels instead of raw

Before this commit:
- Hierarchical charts interpret datasets as labels and the last column
  as values. dataset cells were read as raw values, which is correct for
  other charts but incorrect here because these values are rendered as labels.
- As a result, formatted values were displayed incorrectly in charts
  like Sunburst and Treemap.

After this commit:
- Dataset columns used as labels now use formatted cell values instead
  of raw values, ensuring dates and other formatted types display
  correctly in hierarchical charts.

closes #8133

Task: 5913296
X-original-commit: 5e7fb8c
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com>

Author: rmbh-odoo

src/helpers/figures/charts/runtime/chart_data_extractor.ts

@@ -43,6 +43,7 @@ import {
   CellValue,
   DEFAULT_LOCALE,
   Format,
+  FormattedValue,
   GenericDefinition,
   Getters,
   Locale,
@@ -780,20 +781,42 @@ function fixEmptyLabelsForDateCharts(
   return { labels: newLabels, dataSetsValues: newDatasets };
 }
 
+function getDatasetRange(getters: Getters, ds: DataSet): Range | undefined {
+  if (!ds.dataRange) {
+    return;
+  }
+
+  const labelCellZone = ds.labelCell ? [ds.labelCell.zone] : [];
+  const dataZone = recomputeZones([ds.dataRange.zone], labelCellZone)[0];
+  if (!dataZone) {
+    return;
+  }
+
+  return getters.getRangeFromZone(ds.dataRange.sheetId, dataZone);
+}
+
 /**
  * Get the data from a dataSet
  */
 export function getData(getters: Getters, ds: DataSet): (CellValue | undefined)[] {
-  if (ds.dataRange) {
-    const labelCellZone = ds.labelCell ? [ds.labelCell.zone] : [];
-    const dataZone = recomputeZones([ds.dataRange.zone], labelCellZone)[0];
-    if (dataZone === undefined) {
-      return [];
-    }
-    const dataRange = getters.getRangeFromZone(ds.dataRange.sheetId, dataZone);
-    return getters.getRangeValues(dataRange).map((value) => (value === "" ? undefined : value));
+  const range = getDatasetRange(getters, ds);
+  if (!range) {
+    return [];
+  }
+
+  return getters.getRangeValues(range).map((value) => (value === "" ? undefined : value));
+}
+
+/**
+ * Get the formatted data from a dataSet
+ */
+function getFormattedData(getters: Getters, ds: DataSet): (FormattedValue | undefined)[] {
+  const range = getDatasetRange(getters, ds);
+  if (!range) {
+    return [];
   }
-  return [];
+
+  return getters.getRangeFormattedValues(range).map((value) => (value === "" ? undefined : value));
 }
 
 /**
@@ -1081,13 +1104,13 @@ function getHierarchicalDatasetValues(getters: Getters, dataSets: DataSet[]): Da
     (ds) => !getters.isColHidden(ds.dataRange.sheetId, ds.dataRange.zone.left)
   );
   const datasetValues: DatasetValues[] = dataSets.map(() => ({ data: [], label: "" }));
-  const dataSetsData = dataSets.map((ds) => getData(getters, ds));
+  const dataSetsData = dataSets.map((ds) => getFormattedData(getters, ds));
   if (!dataSetsData.length) {
     return datasetValues;
   }
   const minLength = Math.min(...dataSetsData.map((ds) => ds.length));
 
-  let currentValues: (CellValue | undefined)[] = [];
+  let currentValues: (FormattedValue | undefined)[] = [];
   const leafDatasetIndex = dataSets.length - 1;
 
   for (let i = 0; i < minLength; i++) {

tests/figures/chart/sunburst/sunburst_chart_plugin.test.ts

@@ -130,6 +130,25 @@ describe("Sunburst chart chart", () => {
     ]);
   });
 
+  test("Sunburst chart display dataset labels in formatted form", () => {
+    // prettier-ignore
+    setGrid(model, {
+      A2: "2/3/2010",   B2: "10",
+      A3: "5/8/2015",   B3: "40",
+    })
+    const chartId = createSunburstChart(model, {
+      dataSets: [{ dataRange: "A1:A3" }],
+      labelRange: "B1:B3",
+    });
+
+    const config = getSunburstRuntime(chartId).chartJsConfig;
+    expect(config.data.datasets).toHaveLength(1);
+    expect(config.data.datasets[0].data).toMatchObject([
+      { value: 40, label: "5/8/2015", groups: ["5/8/2015"] },
+      { value: 10, label: "2/3/2010", groups: ["2/3/2010"] },
+    ]);
+  });
+
   test("Sunburst data is sorted", () => {
     // prettier-ignore
     setGrid(model, {

tests/figures/chart/treemap/treemap_chart_plugin.test.ts

@@ -158,6 +158,30 @@ describe("TreeMap chart", () => {
     });
   });
 
+  test("TreeMap chart display dataset labels in formatted form", () => {
+    // prettier-ignore
+    setGrid(model, {
+        A1: "Date",       B1: "Sales",
+        A2: "2/3/2010",   B2: "10",
+        A3: "5/8/2015",   B3: "40",
+      })
+    const chartId = createTreeMapChart(model, {
+      dataSets: [{ dataRange: "A1:A3" }],
+      labelRange: "B1:B3",
+      dataSetsHaveTitle: true,
+    });
+
+    const datasetConfig = getTreeMapDatasetConfig(chartId);
+    expect(datasetConfig).toMatchObject({
+      tree: [
+        { 0: "2/3/2010", value: 10 },
+        { 0: "5/8/2015", value: 40 },
+      ],
+      groups: ["0"],
+      key: "value",
+    });
+  });
+
   test("Can have a hierarchical dataset with some categories more detailed that others", () => {
     // prettier-ignore
     setGrid(model, {