[FIX] standalone_composer: wrong composer content on start edition

When we have the pivot side panel open and that someone in collaborative
updates a calculated measure formula, the composer correctly shows the
updated formula. But if the composer is focused, it will show the
previous formula instead of the updated one.

This happens since 53f7692. In this commit, we update the composer
store `this.editionMode` before calling `getComposerContent`, which make
sense. But the `getComposerContent` implementation of the standalone
composer store does not return the updated formula if
`this.editionMode` is not inactive.

With this commit, `getComposerContent` of the standalone composer always
returns the updated formula and never the current store state. I don't
think it should cause any issues, since `getComposerContent` is only
called when displaying the inactive composer content, and when
starting the edition. In both cases, we want to show the updated
formula.

closes #8102

Task: 6022743
X-original-commit: 4052315
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Author: hokolomopo

src/components/composer/standalone_composer/standalone_composer_store.ts

@@ -47,22 +47,19 @@ export class StandaloneComposerStore extends AbstractComposerStore {
   }
 
   protected getComposerContent() {
-    let content = this._currentContent;
-    if (this.editionMode === "inactive") {
-      // References in the content might not be linked to the current active sheet
-      // We here force the sheet name prefix for all references that are not in
-      // the current active sheet
-      const defaultRangeSheetId = this.args().defaultRangeSheetId;
-      content = rangeTokenize(this.args().content)
-        .map((token) => {
-          if (token.type === "REFERENCE") {
-            const range = this.getters.getRangeFromSheetXC(defaultRangeSheetId, token.value);
-            return this.getters.getRangeString(range, this.getters.getActiveSheetId());
-          }
-          return token.value;
-        })
-        .join("");
-    }
+    // References in the content might not be linked to the current active sheet
+    // We here force the sheet name prefix for all references that are not in
+    // the current active sheet
+    const defaultRangeSheetId = this.args().defaultRangeSheetId;
+    const content = rangeTokenize(this.args().content)
+      .map((token) => {
+        if (token.type === "REFERENCE") {
+          const range = this.getters.getRangeFromSheetXC(defaultRangeSheetId, token.value);
+          return this.getters.getRangeString(range, this.getters.getActiveSheetId());
+        }
+        return token.value;
+      })
+      .join("");
     return { text: localizeContent(content, this.getters.getLocale()) };
   }
 

tests/pivots/pivot_side_panel.test.ts

@@ -212,6 +212,38 @@ describe("Pivot side panel", () => {
     expect(definition.collapsedDomains?.ROW).toHaveLength(0);
   });
 
+  test("External update of the calulated formula impacts the side panel", async () => {
+    // prettier-ignore
+    setGrid(model, {
+      A1: "Partner", B1: "Amount",
+      A2: "Alice", B2: "10",
+      A5: "=PIVOT(1)"
+    });
+
+    const sheetId = model.getters.getActiveSheetId();
+    const calculatedMeasure = {
+      id: "calc",
+      fieldName: "calc",
+      aggregator: "sum",
+      computedBy: { formula: "=25", sheetId },
+    };
+    updatePivot(model, "1", { measures: [calculatedMeasure] });
+    env.openSidePanel("PivotSidePanel", { pivotId: "1" });
+    await nextTick();
+
+    expect(".o-sidePanel .o-composer").toHaveText("=25");
+
+    updatePivot(model, "1", {
+      measures: [{ ...calculatedMeasure, computedBy: { formula: "=50", sheetId } }],
+    });
+    await nextTick();
+    expect(".o-sidePanel .o-composer").toHaveText("=50");
+
+    // Focus the composer. It should stay the same value
+    await simulateClick(".o-sidePanel .o-composer");
+    expect(".o-sidePanel .o-composer").toHaveText("=50");
+  });
+
   test("Collapsed dimension with correct field but wrong value is not filtered out at pivot update", async () => {
     // Note: we don't want to remove those, because different users may have different value,
     // and a domain might be valid for one user and not for another